use × instead of x

Still a valid issue. See for example the description text for a user picture upload form. Moving to 8.x.

subscribe

subscribe

Here are some changes about that. I also change the test according to the new × instead of x

why it's using str_replace ??

Because the informations is still save with the x (the letter), not the × so the only purpose of this replace is to display a × instead of the x when displaying the data. (but I know, that still might be a bad idea ... )

-    watchdog('image', 'Image scale failed using the %toolkit toolkit on %path (%mimetype, %dimensions)', array('%toolkit' => $image->toolkit, '%path' => $image->source, '%mimetype' => $image->info['mime_type'], '%dimensions' => $image->info['width'] . 'x' . $image->info['height']), WATCHDOG_ERROR);
+    watchdog('image', 'Image scale failed using the %toolkit toolkit on %path (%mimetype, %dimensions)', array('%toolkit' => $image->toolkit, '%path' => $image->source, '%mimetype' => $image->info['mime_type'], '%dimensions' => $image->info['width'] . '×' . $image->info['height']), WATCHDOG_ERROR);

This (and others) look wrong. The % in %dimensions means that the argument is plain-text. As consequence it should not contain HTML. Moreover, we try to avoid using entities, and prefer straight Unicode characters.

Got it, what about this one so ?

Reposting patch from #9 without modification, in attempt to get the testbot to run.

Re-rolled patch against current D8 head, and in -p1 format for the testbot.

Patch did not work. Could not get it to apply to 8.x-dev.

I get: fatal: corrupt patch at line 139

Rerolled to the recent head. Noob input.

Patch needs rerolling again.

14: 657166-14.patch queued for re-testing.

Ok, this needs a bunch of work. Where is the image_resize_effect() function? I could only find the test:

grep -ir image_resize_effect core/modules/
core/modules//image/src/Tests/ImageEffectsTest.php: * Test the image_resize_effect() function.

same for function image_crop_effect() & image_scale_and_crop_effect().

or for that matter core/modules/user/lib/Drupal/user/AccountFormController.php

This still needs work obviously, but wanting the bot to test it.

+++ b/core/modules/file/file.field.inc
@@ -185,8 +185,8 @@ function template_preprocess_file_upload_help(&$variables) {
+    $max = str_replace('x', '×', $upload_validators['file_validate_image_resolution'][0]);
+    $min = str_replace('x', '×', $upload_validators['file_validate_image_resolution'][1]);

I think that should not be necessary.
Instead everywhere where 'x' is still used we should use the proper character instead. I could find the following places that still need to updated:
EditorImageDialog
ImageItem (there's some instances of x there)

Ok, I dropped the str_replace() as requested and added it to EditorImageDialog & ImageItem. Let me know if I missed anything.

Hope this addresses the failed test in core/modules/image/src/Tests/ImageFieldDisplayTest.php

This should take care of the tests.

You forgot to change one of the "WIDTHxHEIGHT" that appears in the patch.

Ok, this should address that. Thanks for pointing it out TR.

Seems like a very unrelated failure to me.

I posted a version of the code on SimplyTest.me - admin/structure/types/manage/article/fields/node.article.field_image

I noticed it isn't in admin/config/media/image-styles when I was looking at this just now... That's probably the biggest place where it is visible in the UI.

Now with changes to the image module.

Sorry for the noise. Missed the YML file.

and small/medium too apparently..

Screenshot with ×

With tests..

Awesome, thanks! The patch is now a simple search and replace, which is how it should be. The various test failures show that this is sufficiently tested.

Wonderful :)

Committed/pushed to 8.0.x, thanks!

Almost 5 years now, wow :)

This broke stuff. We should have only change UI text here. See #2363077: Max and min resolution not working and #2387011: EditorImageDialog passes incorrect arguments to file_validate_image_resolution