I upgraded to drupal 6.14 and also upgraded the signup module. I have a limit of "1" sign-up available on all nodes and they close after one person signs-up; the last version of signup worked great for this. I can't get the limit to work - the nodes do not close when limit is met. I can close them manually. The database is not being updated after a user signs-up. Do I now need to use the signup-status module for this feature?

CommentFileSizeAuthor
#2 597808-2.signup_limit_fix.patch706 bytesdww
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dww’s picture

dww
we/he/they
CreditAttribution: dww commented
Title: Status open/close - signup does not closed when limit is reached » Signup does not close when limit is reached
Component: Database » Code
Assigned: Unassigned » dww

#598164: Signup Limit set to '1', signups won't close marked duplicate of this. Sounds like a bug. I'll have to look into it. I think in all my testing with signup_status, somehow I didn't test this with just signup. Alas... Anyway, stay tuned.

dww’s picture

dww
we/he/they
CreditAttribution: dww commented
Status: Active » Needs review
FileSize
597808-2.signup_limit_fix.patch706 bytes

Yup, that was exactly the problem. Just missing a default for something important when signup_status is not altering it. :( This patch works fine for me -- anyone else care to test to confirm it solves what they're seeing?

rosemeria’s picture

rosemeria CreditAttribution: rosemeria commented
Category: bug » task

I'll test it but you'll will need to tell me exactly where to put the patch. sorry a newbie.

Which file and which line do i put this patch?

$signup->count_towards_total = 1;
if (!empty($signup_anon_mail)) {
$signup->anon_mail = $signup_anon_mail;
}

Thanks, Rose

dww’s picture

dww
we/he/they
CreditAttribution: dww commented
Category: task » bug

@rosemeria: No problem, I'm glad to help...

First, this issue is describing a bug in signup.module, so even though we all have various tasks to accomplish (you have to apply a patch and test it, I have to commit the patch, eventually make a new release, etc), the issue itself is still a bug. ;)

Second, don't use that code from the other issue. That's not going to help you. Instead, you want to apply the patch I posted at comment #2 (597808-2.signup_limit_fix.patch). When in doubt, always trust code from the maintainer of a module, not a random user from the issue queue. ;)

Third, to learn about what patch file is and how to use it, please read http://drupal.org/patch and http://drupal.org/patch/apply

Cheers,
-Derek

rosemeria’s picture

rosemeria CreditAttribution: rosemeria commented
Priority: Normal » Minor

Hi Derek,
The patch is working great. I have completed tests on two drupal 6 installs. I am now ready to place it into action for our parent-teacher conferences. We are a small charter school in Hawaii and appreciate your help, most of all thanks for this great module. Our teachers have more time to spend with their students because of you!

Aloha,
Rose

dww’s picture

dww
we/he/they
CreditAttribution: dww commented
Priority: Minor » Normal
Status: Needs review » Fixed

@rosemeria: Thanks for the kind words, and for testing the patch!

Since we've both confirmed the patch works, I just committed the fix to both the HEAD and DRUPAL-6--1 branches. So, this will be available in the next release (rc7).

However, just because you patched your site to work-around the problem doesn't mean this is now a "minor" bug. In fact, I'd almost call this "critical" since it's a pretty central piece of functionality that's now broken. But, let's call it "normal" and be done with it. ;)

Anyway, thanks for reporting and for your help getting it fixed.

Cheers,
-Derek

intent’s picture

intent CreditAttribution: intent commented

Thanks for the fix Derek, your time and attention, and of course your incredible module, are much appreciated.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

zdean’s picture

zdean CreditAttribution: zdean commented
Status: Closed (fixed) » Active

Is there a timetable for the rc7 release?

Thanks for this great module.

dww’s picture

dww
we/he/they
CreditAttribution: dww commented
Status: Active » Closed (fixed)

Please don't re-open old bug reports that are already closed unless the exact bug is still present in the latest -dev release. Thanks.

babbage’s picture

babbage CreditAttribution: babbage commented
Priority: Normal » Critical

Hang of a long time to wait for a new release for something as critical as this. I'll move to -dev, but it'd be great to see that RC7 soon... :)

koosvdkolk’s picture

koosvdkolk CreditAttribution: koosvdkolk commented

The patch in #2 worked, but sometimes the node is closed only after the limit+1 is reached.

E.g. the limit is 6, there are 6 people in the node, but I still can signup. When I do, the node is closed. When I cancel my signup, the node stays closed.