Smileys module seems to unecessarily overwrite some jquery-ui functions. This happened to me when using jquery_update, and jquery_ui (with latest jquery ui 1.7). In my case .draggable() did not work anymore.
It seems that one part of jquery_ui (ui.core.dialog.js) has been forgotten to be switched off, when jquery_ui is active.

The attached patch solved this problem.

CommentFileSizeAuthor
#10 smileys-jquery-ui-conflict-590856-10.patch605 bytesdreamdust
smileys-jquery_ui.patch741 bytesderhasi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Tigerboy’s picture

Tigerboy CreditAttribution: Tigerboy commented

Jquery_ui is unable to even install in many peoples cases and the Jquery_ui project is just deleting peoples issues on the subject. This should be removed as a functional project. They shouldn't be able to say "well it works for me" and delete peoples issues from the que.

Michsk’s picture

Michsk CreditAttribution: Michsk commented

@tigerboy: i totally understand where you are comming from, but there are people who got it working and are using it. I really +1 for this update and hope you will implement it, for the users who do not use jquery_ui it will not harm nor change anything. For those that do use the ui module you will be a hero.

aaron’s picture

aaron CreditAttribution: aaron commented
Status: Needs review » Reviewed & tested by the community

+1 for the patch; 46k sites are reporting they have jquery_ui working properly: http://drupal.org/project/usage/jquery_ui

fenda’s picture

fenda CreditAttribution: fenda commented

+1 for an update. We want to integrate smileys module with our project but it is simply impossible without fixing this.

rv0’s picture

rv0 CreditAttribution: rv0 commented

i was about to type +1

but then i figured I just use it for the jquery ui calendar popup.. which I didn't need after all, so I switched it off on my site.
EDIT: I did need it so I decided to use the patch and so far it works.

in any case.. this is a problem, wether it's the smiley module's fault or jquery ui's fault, it should be addressed in the best possible way.

manos_ws’s picture

manos_ws CreditAttribution: manos_ws commented

when I apply the patch I get

in smileys.js

Line 42:    $(this).dialog is not a function

I tested it with draggable and resizable set to on and off.

Without the patch when I what resizable set to on

I get

in ui.core.dialog.js

Line 1: D[G][E] is not a constructor

When I have both draggable and resizable se to off it works without out errors (without the patch)

Manos
http://websynergy.gr/

rv0’s picture

rv0 CreditAttribution: rv0 commented

exact same issue

Line 42:    $(this).dialog is not a function

not a clue at what is causing it

emdalton’s picture

emdalton CreditAttribution: emdalton commented

Thank you. This finally fixed my problem with the Smileys popup.

fenda’s picture

fenda CreditAttribution: fenda commented

This patch works. It's so simple and safe, why is it not applied yet? :P

dreamdust’s picture

dreamdust CreditAttribution: dreamdust commented
Version: 6.x-1.x-dev » 6.x-1.0
Status: Reviewed & tested by the community » Needs review
FileSize
smileys-jquery-ui-conflict-590856-10.patch605 bytes

The first patch doesn't work. If it detects jquery_ui it won't load "ui.dialog" resulting in the error:
$(this).dialog is not a function

I fixed the problem by including "ui.dialog" from jquery_ui if it exists. Here's a new patch.

fizk’s picture

fizk CreditAttribution: fizk commented

If anyone's interested, I've committed this fix in the cousin module "smiley":

#1817368: Jquery UI conflict