Unable to edit the node meta tags unless the user has permission "administer nodes"

From the documentation/discussions, i think it should be possible to edit the meta tags for a non-admin user if they have permission for that specific meta tag.

That is true for the meta tags associated to nodes, or user profiles; if you want to change the default meta tags value, or the meta tags associated with the error 403 page, the error 404 page, the front page, the tracker page, or other custom pages then you need an administration permission.

Did I understand what you are saying, or did I miss anything?

To which meta tags are you referring?

- When it's on, I can edit the meta tags for a node.

Then you are referring to the node meta tags. That is all I wanted to know; thanks for the clarification.

The code was supposed to allow a user with permission to administer nodes to edit the node meta tags.

The code has been changed, and committed in CVS.
Thanks for your report.

So, I don't get it... The issue marked "fixed" but i don't see how it fixed? I have the same problem and i don't want to grant my newsmakers the "administer nodes" permission... but i want them to fill the meta tags.

Using In v1.0 this could be done without granting "administer nodes" permission, what know?

UPD: OK, i manually searched trough the CVS repository and here is a patch for this issue (posting here so others don't have to search):

 <?php
-// $Id: nodewords.module,v 1.57.2.159 2009/09/27 14:39:12 kiam Exp $
+// $Id: nodewords.module,v 1.57.2.160 2009/09/27 16:51:00 kiam Exp $
 
 /**
  * @file
@@ -583,14 +583,12 @@
       }
     }
 
-    if (!$options['page:administrative'] && ((!empty($options['page:permissions:additional']) && !user_access($options['page:permissions:additional'])) || (!empty($info['widget:permission']) && !user_access($info['widget:permission'])))) {
-      continue;
-    }
+    if ($options['page:administrative'] || ((!empty($options['page:permissions:additional']) && user_access($options['page:permissions:additional'])) || (!empty($info['widget:permission']) && !user_access($info['widget:permission'])))) {
+      if (function_exists($function = $info['tag:function:prefix'] . '_form')) {
+        $tag_options['parameters'] = !empty($info['tag:function:parameters']) ? $info['tag:function:parameters'] : array();
 
-    if (function_exists($function = $info['tag:function:prefix'] . '_form')) {
-      $tag_options['parameters'] = !empty($info['tag:function:parameters']) ? $info['tag:function:parameters'] : array();
-
-      $function($form, isset($tags[$name]) ? $tags[$name] : array(), $tag_options);
+        $function($form, isset($tags[$name]) ? $tags[$name] : array(), $tag_options);
+      }
     }
   }

Thanks for fixing it!

I have marked #597420: Only admin can see fields for editing as duplicate of this report.

Hi,

I also updated to the latest version and even logged as admin i cannot edit any metatag, what happens ?

When clicking any tab of the module configuration I see:
"No meta tags have been enabled for editing; enable them on the settings page."

When I go on the settings page there is nothing under "Tags to show on edit forms" and "Tags to output in HTML" ?!

What should I do ?

Thanks.

hi, i had the same problem. What i found is just a typing mistake in .module file that is

In nodewords_form_alter function()

 if (variable_get('nodewords_edit_metatags' . $form['type']['#value'],TRUE))  
 // change to  
 if (variable_get('nodewords_edit_metatags_' . $form['type']['#value'],TRUE))
 // needs a underscore at the end of nodewords_edit_metatags
 

And it worked for me.

No need to give administer nodewords permissions to users, just allow tags permission for example this
'edit description meta tag' for authenticated user and then that particular user would be able to see tag fields.

Hi,

I made the change and added underscore but still have the same problem and nodes do not have any metatags.

Thanks for help.

hmm, im going to tell you the steps that i followed in order to show the metatags in particular nodes without giving administrator permissions to the user.

on admin/user/permissions in nodewords module give permissions for edit description meta tag and edit keywords meta tag since these are the most important tags.

on admin/content/node-type/your-content find nodewords settings and mark the checkbox saying 'Allow editing of meta tags'. This checkbox was not working for me then i made the above change and it worked.

so give it one more try

Sorry, it seems that my problem was that I didn't enabled the new modules when updating, so I needed to check the box in front of :

Basic meta tags
Extra meta tags
Site verification

Because with the former Nodewords module there was only Nodewords to enable.

I will report in case of other problems.

Thank you again.

I have marked #599062: Metatags fields not showing in content edit/create forms except for administrators as duplicate of this report.

I have installed Nodewords 6.x-1.2

Enabled Nodewords, Basic meta tags, & Extra meta tags
Given myself permissions to administer nodewords

As per [abrar.ars - October 7, 2009 - 10:05] I have performed the edit to

if (variable_get('nodewords_edit_metatags_' . $form['type']['#value'],TRUE))
// needs a underscore at the end of nodewords_edit_metatags

Yes, I still have the same problem and none of the nodes have any metatags.

In addition, in Administer › Content management > Nodewords where it says:

Tags to show on edit forms
Select the meta tags you want to be able to edit on the edit page of nodes, terms and vocabularies.

...there is nothing written

Any thoughts? Thanks

I have marked #600226: Node meta tags disappeared as duplicate of this report.

I have marked #599540: Nodewords from all nodes has disappeared as duplicate of this report.

I have this problem too.
Install Nodewords 6.x-1.2, 6.x-1.1.
Change nodewords_edit_metatags to nodewords_edit_metatags_
No effect. List of tags is empty for user #1.

subscribing having the same problem
kinda looks as it "just dosnt work" (iknow thats a sucky report)

so how come its set to fixed?

got the fix ;)
figured out that a good cleaning of the cache did wonders *doh*

So far I don't see why my original post was forwarded here so I'm going to state my problem.

All my past nodes before this update aren't showing their keywords or desciptions.
I've gone into the admin/content/nodewords settings and activated for the types of nodes I want.

When I VIEW SOURCE there's no meta tags of descriptions or keywords for the OLD nodes but there are descriptions and keywords for the NEW nodes.

Basically all my past nodes aren't showing the old meta tag data.

I'm just hoping it's a code problem that isn't looking at the meta tables in the database.

If not.. I really screwed the pooch on this one.

Please help. This is extremely important.

Thank you for your time.

I believe there's a typo in the committed fix, instead of

if ($options['page:administrative'] || ((!empty($options['page:permissions:additional']) && user_access($options['page:permissions:additional'])) || (!empty($info['widget:permission']) && !user_access($info['widget:permission'])))) {

it should be

if ($options['page:administrative'] || ((!empty($options['page:permissions:additional']) && user_access($options['page:permissions:additional'])) || (!empty($info['widget:permission']) && user_access($info['widget:permission'])))) {

eg. if $info['widget:permission'] is set and user has $info['widget:permission'] permissions user should be able to see nodewords form fields.

I fixed the code as reported by nonsie, and I removed one useless couple of parentheses.

The committed code change the reported IF-statement in

    $bool = (
      $options['page:administrative'] ||
      (
        !empty($options['page:permissions:additional']) &&
        user_access($options['page:permissions:additional'])
      ) ||
      (
        !empty($info['widget:permission']) &&
        user_access($info['widget:permission'])
      )
    );

    if ($bool) {

If I would have written it this way, I would have noted before the code was wrong.

Thanks to nonsie for the help in resolving the issue.

I dont think this issue ist fixed!

I have upgraded nodewords from 1.1 to 1.2 and now I can not edit meta tags. Not as user1 or any other user. Also the previously inserted meta-tags are no longer inserted to head.

I noticed that there are some changes in the configuration page, but I have checked all preferences a few times and all seems to be set up correctly. (for each content type meta-tags are selected - but I can not edit nor view the old meta tags)

please let me know what the upgrade issue might be, or how can I downgrade to previous version.

thanx a lot in advance!

@danoguru: See the referring version; an official release cannot be changed, if not creating another official release, which is created from the development snapshot.

Clear your cache and be sure all the nodeword modules are still enabled.

I don't see what this if statement (nodeworks.module:665) is meant to achieve anway. If the condition is true, continue? It's going to continue anyway.

I applied the code in #23 just to see what it would do and the meta fields disappear in the edit form even for roles that have "administer nodes" -- so I don't know what's going on here. I would upgrade to dev, but there's a rather ominous warning on the project page.

ok, I checked the modules and found out that i had to enable new module "Basic meta tags"... I dont understand why the module was not enabled automaticaly on module update!! Now all my meta-tags are back :)

I have all modules enabled.
I have all settings checked.
I'm able to write NEW meta tags.

But all my old meta tags aren't showing.
Only new ones posted after upgrade show.

[Edited by KiamLaLuno to remove all the header tags]

Hi,

I've the same problem.
I don't view fields to insert metatags.

See the referring version. An official release cannot be changed if not creating a new official release, whose code is created from the development snapshot.

so how can we solve this problem?
Have we to wait a new stable version?

thanks ;)

Subscribing. Exactly the same problems. I need to give the user "administer nodes" rights in order for him to edit the meta tags.

#31:

See the referring version. An official release cannot be changed if not creating a new official release, whose code is created from the development snapshot.

I'm pretty sure he is saying that the fix is in the DEV version. I had tried the DEV version, but ran into a nasty bug that seems to have been fixed (#604160: Call to undefined function drupal_get_install_files() in nodewords.module line 1084) as of yesterday and there is a new DEV version today. I'm going to give it another go.

I'm pretty sure he is saying that the fix is in the DEV version.

Yes; that is what I meant. That is also the reason the referring version (field Version of the fieldset Edit issue settings) is set to 6.x-1.x.

I just noticed an alpha version is available -- thanks for addressing these issues. Checking it out now. Works great!!!

not working for me, even for dev version and all the "new" modules activated :-(

i was using 6.x-1.0 version

I am now experiencing this problem with 6.x-1.3-beta5, on forum topics but not a custom content type.

I have 3 nodeword modules enabled: Nodewords, Basic & Extra

I've checked and the option "Allow editing of meta tags" is properly set on each content type.

I've also cleared the cache.

Is anyone else experiencing this? Any suggestions?

Ok seems that this issue is a very long one.
I personnally experienced several issues upgrading to the 6.x-1.1 version (all my settings were lost due to the change of the module structure with its submodules). Resolved this one by de-activating the module, running update.php, re-activating the module and the needed submodules, and run update.php again.
Many people are complaining about that in this issue, although it's not the same original issue.

I'm using 6.x1-2 on my site, didn't test dev version and 1.3-betax

For the original issue, I've found in the module code that one can not edit meta tags fields like "description" or "keywords" if one does not have the "administer nodes" permission, even if :
* nodewords settings are properly configured, modules activated for the desired meta-tags
* the relative checkbox has been checked in the content type edit page
* the user has been given the right "edit xxx tags" in the permissions settings

This is by design (at least in the code), in the form_later function invoked for the node editing forms, line 77 in nodewords.module :

 $form['nodewords'] = nodewords_form(
        'node',
        $tags,
        array(
           'page:permissions:additional' => 'administer nodes',
        )
      );

Later on in the code, there is an escaping point ("continue;") from the main iteration in the nodewords_form() function which doesn't make the generation of the form nodewords elements, if you don't have "administer nodes" permission (line 665) :

if (!$options['page:administrative'] && ((!empty($options['page:permissions:additional']) && !user_access($options['page:permissions:additional'])) || (!empty($info['widget:permission']) && !user_access($info['widget:permission'])))) {
      continue;
    }

I've written a small patch (maybe the smallest drupal patch :)) which works fine for me, and is attached to this post.
Once again, I don't know if it's a real issue or if it's by design, so I'm not sure of my status change.

This can be improved within the module's roadmap, which I'm not very aware of.

Best regards

The code has been already changed in the development snapshot.

    $bool = (
      (
        !empty($options['page:permissions:additional']) &&
        user_access($options['page:permissions:additional'])
      ) ||
      (
        !empty($info['widget:permission']) &&
        user_access($info['widget:permission'])
      )
    );

    if ($bool) {
      if (function_exists($function = $info['tag:function:prefix'] . '_form')) {
        $tag_options['parameters'] = !empty($info['tag:function:parameters']) ? $info['tag:function:parameters'] : array();

        $function($form, isset($tags[$name]) ? $tags[$name] : array(), $tag_options);
      }
    }
  }

ok thanks for the update , will it be changed in the next 6.x-1.3 stable release ?

will it be changed in the next 6.x-1.3 stable release ?

It is already included in the last official releases.

As I said, I'm using 6.x-1.3beta5, so the latest release which has the change KiamLaLuno refers to.

slybud - Thanks, I tried your patch and the disable/update/enable/update/check process, but still no luck, so I'm still stuck with experiencing the problem.

I am restoring the status as set by ailgm.

We also experienced this problem. We received a notification of a security update for this module and installed the recommended version, 6.x-1.2 (2009-Sep-23), which broke meta tags for everyone except administrators. We also tried 6.x-1.3-beta5 (2009-Oct-30) on a test server and experienced the same problem. Permissions and configuration settings were set correctly.

Just to confirm..

I've used latest CVS version for 6.x-1.x-dev, and performed the following steps:
- Login as an user with permissions: "administer content types" and "administer meta tags".
- Go to edit "Page" content type, and mark the checkbox "Allow editing of meta tags". (This step is optional, I've verified later).
- Go to Administer nodewords, "Meta tags to show on edit forms" (at admin/settings/metatags) and enable: "Keywords", "Copyright", and "Description" checkboxes.
- Logout this user.
- Login as an user with permissions to 'create page content', 'edit meta tag DESCRIPTION', and 'edit meta tag COPYRIGHT'.
- Go to add page content: node/add/page and found: Description and Copyright fields are there, keywords field is not there.

Works perfect I'd say. I've also verified this works in 6.x-1.3-Beta5. I'd mark as fixed once for all, but would like to hear KiamLaLuno's opinion first.

I've attached the test file to keep a check on this in the future..

Thanks for your confirmation, ilo. I am changing the status of this report to fixed.

The test file you attached will be part of the next commit I will do in the next 24 - 36 hours.
Maybe I will add some more test to the test file you provided (thanks again for your help, ilo). I was thinking to add some tests for some functions that are important for the module to work.

Thanks to you for all the good job.

subscribe

This bug is present in the shiny new 6.x-1.3

You mean 1.13 ;-) I'll review this.

Absolutely right :)

There really needs to be a standard way of defining permissions, without having to add another layer of complexity.

Try this out for size, it adds a new array of permissions, one for each object type, i.e.:

// A string used to prefix permissions.
define('NODEWORDS_PERM_TYPE_PREFIX', 'manage meta tag type ');

and

function nodewords_perm() {
  return array(
    'administer meta tags',
    NODEWORDS_PERM_TYPE_PREFIX . NODEWORDS_TYPE_DEFAULT,
    NODEWORDS_PERM_TYPE_PREFIX . NODEWORDS_TYPE_ERRORPAGE,
    NODEWORDS_PERM_TYPE_PREFIX . NODEWORDS_TYPE_FORUM,
    NODEWORDS_PERM_TYPE_PREFIX . NODEWORDS_TYPE_FRONTPAGE,
    NODEWORDS_PERM_TYPE_PREFIX . NODEWORDS_TYPE_NODE,
    NODEWORDS_PERM_TYPE_PREFIX . NODEWORDS_TYPE_OFFLINE,
    NODEWORDS_PERM_TYPE_PREFIX . NODEWORDS_TYPE_PAGE,
    NODEWORDS_PERM_TYPE_PREFIX . NODEWORDS_TYPE_TERM,
    NODEWORDS_PERM_TYPE_PREFIX . NODEWORDS_TYPE_TRACKER,
    NODEWORDS_PERM_TYPE_PREFIX . NODEWORDS_TYPE_USER,
    NODEWORDS_PERM_TYPE_PREFIX . NODEWORDS_TYPE_VOCABULARY,
    // These don't need permissions defined.
    // NODEWORDS_PERM_TYPE_PREFIX . NODEWORDS_TYPE_NONE,
    // NODEWORDS_PERM_TYPE_PREFIX . NODEWORDS_TYPE_PAGER,
  );
}

With these new permissions you'll be able to assign the "manage meta tag type 5" permission to someone and they'll be able to edit metatags on node pages. Obviously the numbers are going to be very obscure, that's kinda an architectural problem split between Nodewords and D6, which doesn't have D7's permission description. I might add a table somewhere that defines the permissions as a cheat sheet, but I really don't want to rearchitect the whole thing just to add this.

I'm not happy with this approach.

I'm postponing this 'til v2.

Marking all v2 issues as postponed while v1 is finished off.

On last 1.4beta2 only works with "Description" and "Canonical URL". Weird that something so basic for team management could have been postponed...

Unfortunately this module is no longer supported, so I'm closing this issue.