Commercial version SWF [#579950]

I don't suppose using the licensed version of flowplayer is documented anywhere? Because the commercial version of flowplayer is actually a different shockwave file - so just setting the license key in the module settings has no effect.

What I had to do was download the 3.1.2 version of flowplayer (as opposed to the latest 3.1.3 version which causes conflicts with this module as it assumes 3.1.2 js, etc) and then rename the flowplayer.commercial-3.1.2.swf to flowplayer-3.1.2.swf. This seemed to work.

Looking over the module sourcecode, I notice there's a static variable for $flowplayer_added, which when set, ignores adding the flowplayer swf files to the site. Was this variable intended to be set when themers/module add the flowplayer themselves, or does it have another purpose? Wouldn't it be better to just remove all the static variables and just have a theme function that can be overridden when needed? I can write a patch for this if you like.

Thanks.

Comment	File	Size	Author
#6	commercial.patch	1.18 KB	jbrown
#5	commercial.patch	1.9 KB	RobLoach

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

RobLoach

he/him

CreditAttribution: RobLoach commented 17 September 2009 at 23:37

Title:	Applying the commercial version	» Commercial version SWF
Category:	support	» bug
Priority:	Normal	» Critical

When the license key is filled in, should we have a field where you could upload your own flowplayer.swf? How do you think the workflow should work?

$flowplayer_added makes it so that it only adds the global Flowplayer JavaScript settings and JavaScript file once per page-load. Even though you can have multiple Flowplayer objects on the page, you only need the settings and the file once. There is a theme function: theme('flowplayer') ;-) . You need $flowplayer_added, as it's part of the magic that applies the effects to all the flowplayer objects through the JavaScript.

Setting this to critical so that we have this feature in before 1.0 is release.

Comment #2

alexkb CreditAttribution: alexkb commented 21 September 2009 at 12:08

Hi Rob,

Thanks for the attention to this issue and explanation on the functionality.

Perhaps keep the uploading of new swf and js files to the administrators (with ftp access) but:

* detect what versions of flowplayer are found (i.e. leave the flowplayer files labeled as flowplayer-3.1.4.swf etc) and in the flowplayer settings let the user select which version to use. It shouldn't pose a problem to people installing newer versions into the same flowplayer folder as they are shipped with unique names by flowplayer dev's anyway (at present).

* When the license key is set try to detect if the flowplayer.commercial-3.1.4.swf version exists and use it?

I'm going to be afk for a few weeks on holiday, but if its not sorted when I get back, ill sort out a patch. Cheers!

Comment #3

travisc CreditAttribution: travisc commented 25 November 2009 at 18:54

Totally agree with the above comments, what's the status?

Because there are a number of features enabled with the commercial version it would be cool to have some control here.

Commercial versions
All commercial versions have the following features in addition to the features that are included in the Free version:

* They do not display any Flowplayer logos, i.e., they are completely un-branded.
* You can have your own logo and place it below or above the screen. You can define whether your logo is visible all the time or only when displaying Flowplayer at fullscreen. Your logo can be scripted.
* The context menu that opens by right-clicking the video area can be customized.
* The big play button shown in the center of the video area can be customized with your own graphics.
* You are allowed to run third-party plugins with the player.

Personally i think being able to upload a custom logo and play button would be a cool feature for this module to support. As well as a text area for the right click context.

Comment #4

jbrown CreditAttribution: jbrown commented 7 February 2010 at 19:49

Can't we just provide the commercial swf and use it when the key is present?

Comment #5

RobLoach

he/him

CreditAttribution: RobLoach commented 8 February 2010 at 08:02

Status:

Active

» Needs review

File	Size
commercial.patch	1.9 KB

Maybe something like this? Not sure we can distribute the commercial Flowplayer swf.

Comment #6

jbrown CreditAttribution: jbrown commented 8 February 2010 at 20:44

File	Size
commercial.patch	1.18 KB

I think its better to just have better instructions, telling the admin that flowplayer.swf needs to be overwritten.

Comment #7

RobLoach

he/him

CreditAttribution: RobLoach commented 9 February 2010 at 01:44

But if they update the Flowplayer module then, the open source one would overwrite the commercial one. Maybe we remove the SWF from the module and move to Libraries API so we have sites/all/libraries/flowplayer/flowplayer.swf? Hrrrrmmmmmm.....

Comment #8

jbrown CreditAttribution: jbrown commented 9 February 2010 at 03:30

Yeah I think we should move to libraries API.

Would be good to not have Flowplayer itself in this module.

Unfortunately Flowplayer are still including the version number in the swf filename, which is horrendously stupid!

Comment #9

gilgabar CreditAttribution: gilgabar commented 13 May 2010 at 00:48

The approach used in the Shadowbox module may also be worth considering. It's essentially the same problem and their solution works fairly well. The path to the library is set on the settings page. It defaults to sites/all/libraries but the end user can set it to whatever they like including version numbers or anything else.