Motivation

For some users, entering the flickr id for an asset (photo or photoset) is not intuitive. When adding an image, the user should be able to see what they are adding before submitting the form.

In this patch

This patch comprises an unobtrusive, ahah-paginated javascript flickr image browser for flickrfield, with support for photos and photosets, along with some trivial standards compliant updates to existing flickrfield code.

Flickr Browser is...

... disabled by default and adds a widget setting checkbox to the content type edit form.
... based on unobtrusive javascript to populate the existing flickr id field when an image is clicked.
... compatible with existing flickrfield cck fields.

Flickr Browser is not...

... intended to change the behavior of flickrfield in any way.

Dependencies

ahah_helper
wimleers' patch to teaser.js

CommentFileSizeAuthor
screenshot.png171.94 KBaaronbauman
flickr-browser.patch31 KBaaronbauman

Comments

sirkitree’s picture

sirkitree commented
Status: Needs review » Needs work

The functionality is very nice, I like the browser. Here are my observations after trying this.

Creating a photo: (cool)
Only local images are allowed.

After hitting submit: (not cool)
Only local images are allowed.

The errors in the second screenshot are due to a javascript error concerning the patch you recommend applying to teaser.js. After reverting that patch, the error goes away but I am still at the /node/add/photo page after submission.

aaronbauman’s picture

aaronbauman
he/him
commented

thanks for reviewing, sirkitree.

I think all the issues you mention are rooted in a bug with ahah_helper: #513322: Not being redirected after node creation or edit

That issue vexing and perplexing, and I'm not sure the best way to address it.
Unless someone else has some ideas on how to address #513322, I'll try to take a whack at it soon.

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Needs work » Needs review

I believe this patch will work much more smoothly with this patch to ahah_helper:
#688210: patch to fix bugs using ahah_helper in a CCK widget

Anonymous’s picture

Anonymous (not verified) commented

Hey, Aaron

This looks awesome!

Were you able to resolve your difficulties ?

Best,
Paul Booker

aaronbauman’s picture

aaronbauman
he/him
commented

Paul:
Like I said, this patch works great for me after applying the fixing the bug in ahah_helper.
I've been using it on production sites since my original post with no real issues.
Did you give a try?

Anonymous’s picture

Anonymous (not verified) commented

Hi Aaron,

I shall try out these new features when the related bugs with ahah_helper have been resolved.

Best,
Paul Booker
Appcoast

notrab’s picture

notrab commented

Has anything new happened with this patch? I'm a newbie and am looking for some help. I installed this patch, enabled the browser, and can see the photos/photosets in my flickr create content page. My issues is that when I select a photo, it's not updating the ID field. I'm assuming this is a javascript problem but am not sure where to go from here. I really want to get this working, so any help would be awesome. Thx.

ljsoares’s picture

ljsoares commented

Thanks for the work this worked great.

hasdf’s picture

hasdf commented

Witch version of flickr should I use?

I am unable to patch 6.x-1.2 and 6.x-1.x-dev (following Error).

patching file flickrfield.info
patching file flickrfield.module
Hunk #14 FAILED at 391.
Hunk #15 succeeded at 449 (offset 25 lines).
Hunk #16 succeeded at 468 (offset 25 lines).
Hunk #17 succeeded at 488 (offset 25 lines).
1 out of 17 hunks FAILED -- saving rejects to file flickrfield.module.rej
patching file flickrfield.css
patching file flickrfield.js

Can anybody post his working version?

Martin

narnua’s picture

narnua commented

m0rtel, I was on the same boat - you might want to check out this module:
http://drupal.org/project/flickrbrowser

Just make sure you're using jQuery 1.3 or above.

lolandese’s picture

lolandese commented
Status: Needs review » Fixed

The project mentioned in #10 is an extension module of the Flickr module and seems to offer the requested feature. If the patch posted here adds anything to the Flickr Browser module, feel free to open an issue there to avoid module duplication.

Closing this issue here. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

lolandese’s picture

lolandese commented
Category: Feature request » Task
Issue summary: View changes
Status: Closed (fixed) » Postponed

To include a link to the Flickr Browser module on the Flickr project page once a D7 version is available on D.O. and tested.

Thanks.

lolandese’s picture

lolandese commented
Related issues: +#2158453: Flickrbrowser for Drupal 7
lolandese’s picture

lolandese commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Category: Task » Feature request
Status: Postponed » Needs work

Five years after this is still a good idea, but as we only do critical bug fixed on D6 now (see #2367755: D6 maintenance), I'll tie this issue to D7, for which it is also relevant.

Most logical seems to create a sub-module or independent module based on the patch above and/or https://github.com/freeform/flickrbrowser.git (D7 version of https://www.drupal.org/project/flickrbrowser).

Thanks.

lolandese’s picture

lolandese commented
Component: flickr_field » flickrfield
lolandese’s picture

lolandese commented
Issue tags: +ninja
lolandese’s picture

lolandese commented
Related issues: +#106534: Integrate Flickrstickr