Taxes aren't preserved after an order is completed [#475810]

I thought this came up before, but I couldn't find the relevant issue beyond the one that saw the addition of the tax report module. Basically, if a customer places an order when the sales tax was 8% but that tax rate is then changed, any future updates of that order by an administrator will change the stored tax rate. The taxes module recalculates tax line items based on the current tax rate settings when the submit changes button is clicked. This will inappropriately alter the historical tax collection data preserved in the cart and made available through the tax reports.

There needs to be some way to indicate that an order should not have its taxes recalculated, possibly through the extra tax data that was added to tax line items in that previous patch. I imagine it should be time calculated based on the last time a tax rate was established, but that could use some more thinking.

Comment	File	Size	Author
#2	preserve_taxes.patch	1.35 KB	Island Usurper
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

TR CreditAttribution: TR commented 28 May 2009 at 21:57

Here's one old thread that I remember: http://www.ubercart.org/issue/2028/taxes_order_not_stored_database

Comment #2

Island Usurper CreditAttribution: Island Usurper commented 1 June 2009 at 17:49

Status:

Active

» Needs review

File	Size
preserve_taxes.patch	1.35 KB

Got a patch rolled up. It checks that the order's state is either 'payment_received' or 'completed', and uses the same tax rates that its current tax line items have stored for recalculating the tax amount. I think it's good to recalculate the taxes even when the rates are the same because this is only triggered when changes to the order have been submitted. Something else may have changed, like the delivery address which could affect the tax amounts. In cases when that happens, the customer must be refunded or billed for the new balance.