During a review of #3575461: Cleanup any remaining deprecations it was discovered that deprecated/removed class names of Search module plugins remain in the code. The two old class names are:
In particular, the moved classes, SearchNode and SearchUser, still contain the old class names in comments. But there is at least one other reference to NodeSearch elsewhere.
Update the references to the new plugin names as contained in the Search submodules. Also clean up an outdated reference to NodeSearchHooks being in the node module.
| Comment | File | Size | Author |
|---|
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #4
sapnil_biswas commentedupdated the old NodeSearch and UserSearch class names to the new SearchNode and SearchUser
Comment #5
sapnil_biswas commentedComment #6
sapnil_biswas commentedThe failed tests don't seem to be in the scope, Marking this for review!
Comment #7
dcam commentedThank you for working on this. There are a few instances where we can simply delete the text. Though one is a bit subjective and someone else might disagree with me. I left suggestions on the MR for all of these. Please look them over.
Comment #8
quietone commentedThis should have been done before Search was deprecating. I am adding it a child of the meta to do that deprecation
Comment #9
sapnil_biswas commentedComment #10
sapnil_biswas commentedI have addressed the review feedback by removing the unnecessary constructor docblocks and the @see attribute tag. Please let me know if any further changes are needed!
Comment #11
daffie commentedAll the changes look good to me.
It is a bit confusing. We have the search_node module with the plugin "node_search", which has the class name "SearchNode". The same for the module "search_user.
For me it is RTBC.
Comment #12
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #13
nod_Bot had a nodejs version issue. resolved.
Comment #16
quietone commentedThanks for helping to keep the documentation accurate.
Committed and pushed 4bef24b8d5e to main and 2704d9d41af to 11.x. Did not commit to 11.4.x because the node_user module is not in that version.
Thanks!