Remove updates added prior to 11.3.0 from 12.x

I should make a commit here by the end of the week

Left these hooks as I didn't see them in 11.3.x

locale_post_update_clear_translation_path_config
update_post_update_clear_disk_cache_again

I didn't delete the test fixutres for 10.3, uninstall-ban, contact, history.

One I didn't know what to do with is PreventDowngradeTest

Oh btw I started a new branch just in case I was wildly wrong and didn't want to pollute what quietone started already.

I deleted ViewsConfigUpdaterTest as it was causing test failures not having any tests but felt like we should keep??

Guess only think to do is decide what to do with PreventDowngradeTest and if the old fixtures should be deleted?

All green!

This one could use a review now. I'm not hiding quietones MR just in case I'm wrong.

Rebased

I left several comments on the MR.

I grepped the 11.3.0 tag to find all of the hook_update_N() and post-update functions: grep -rP "function \S+_update_\d+" core and grep -rP "function \S+_post_update_" core. All of the discovered functions are being removed by MR 15419.

Aside from the fixtures noted in my MR comments, I didn't notice any additional removals (related classes, etc) during my read-through of the MR.

Nice finds!

not sure how I missed that announcements one.

I should have unasssigned myself when I got sick with a flu.

I'm so sorry. I didn't do a deep dive on the PreventDowngradeTest earlier. When I did I found a minor change that didn't get made to a comment. Please verify it and feel free to self-RTBC the issue afterward.

That’s the one I wasn’t 100% about just followed the previous one

Over all the changes to the test look good. It's only that one comment that didn't have the version updated. I think there shouldn't be any remaining references to D10.

Will take a look in the morning thanks!

Applied the suggestion, thanks for the review!

Manually checked all removals and they all look correct to me.

Committed and pushed 88187a5ee7e to main. Thanks!

Thank you! This may be the last blocker for deprecating text_with_summary :)

This broke tests running against mysqli.
https://git.drupalcode.org/project/drupal/-/jobs/9442262
https://git.drupalcode.org/project/drupal/-/jobs/9442264

Drupal\Tests\system\Functional\UpdateSystem\PreventDowngradeTest::testDowngradePrevention
The link Continue was not found on the page.
Failed asserting that an array has the key 0.

core/tests/Drupal/Tests/UiHelperTrait.php:450
core/tests/Drupal/Tests/UpdatePathTestTrait.php:57
core/tests/Drupal/FunctionalTests/Update/UpdatePathTestBase.php:216
core/modules/system/tests/src/Functional/UpdateSystem/PreventDowngradeTest.php:101

Drupal\Tests\system\Functional\Update\SequencesTableRemovalUpdateTest::testRunUpdates
The link Continue was not found on the page.
Failed asserting that an array has the key 0.

core/tests/Drupal/Tests/UiHelperTrait.php:450
core/tests/Drupal/Tests/UpdatePathTestTrait.php:57
core/tests/Drupal/FunctionalTests/Update/UpdatePathTestBase.php:216
core/modules/system/tests/src/Functional/Update/SequencesTableRemovalUpdateTest.php:34

MR for fix: https://git.drupalcode.org/project/drupal/-/merge_requests/15507
mysqli job for MR passes: https://git.drupalcode.org/project/drupal/-/pipelines/800108
Was done the same way in #3569127: Add new 11.3.x database dump fixtures, without modules deprecated for removal in 12.x, maybe we want a better way?

Nice catch!

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

The bot is wrong.