Problem/Motivation

The upgrade path tests in mysqli jobs fail when the mysqli module is not installed. Since mysqli jobs aren't typically run until the commit pipelines, this can go uncaught during MR review.

There's a test fixture that installs mysqli on top of the dump, but people need to remember to add it manually to tests, which is not obvious to do.

From #3580877-41: Remove updates added prior to 11.3.0 from 12.x

I think we'd be better off overall if we could get mysqli enabled in the original database dump rather than an extra fixture, but this is fine as a hotfix.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3588702

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

godotislate created an issue. See original summary.

godotislate’s picture

godotislate’s picture

Title: Enabled mysqli in test 11.3 dump » Enable mysqli in test 11.3 dump
godotislate’s picture

Title: Enable mysqli in test 11.3 dump » Install mysqli in test 11.3 database fixture

godotislate’s picture

longwave’s picture

Status: Needs review » Reviewed & tested by the community

LGTM, though 11.x will need a different MR I think? Then we can probably close #3588558: Test failures on 11.x?

godotislate’s picture

Created the 11.x MR https://git.drupalcode.org/project/drupal/-/merge_requests/15689

#3588558: Test failures on 11.x also has a fix for a readonly property on Form object that gets serialized.

godotislate’s picture

11.x PHP 8.3 mysqli job is all passing except the outstanding issue noted on #3588558: Test failures on 11.x with the form tested in NodeAccessRebuildNodeGrantsTest.
https://git.drupalcode.org/project/drupal/-/pipelines/814459

  • catch committed 72095f8d on 11.x
    fix: #3588702 Install mysqli in test 11.3 database fixture
    
    By:...

  • catch committed f7550d6e on main
    fix: #3588702 Install mysqli in test 11.3 database fixture
    
    By:...
catch’s picture

Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed the respective MRs to main and 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.