Closed (fixed)
Project:
Drupal core
Version:
main
Component:
Admin theme
Priority:
Normal
Category:
Plan
Assigned:
Unassigned
Reporter:
Created:
2 Mar 2026 at 09:45 UTC
Updated:
1 Oct 2026 at 15:45 UTC
Jump to comment: Most recent
There are thousands of references to "gin" in core/themes/admin:
$ rg '\Wgin' core/themes/admin|wc -l
3213
We chose not to ship the name "gin" with core, so we should remove all remnants of the name.
Given this affects things like CSS variables and class names this feels like a blocker for marking the theme as stable.
Replace them with "admin" or something else. Make child issues to scope this work.
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
longwaveIn fact given that there are thousands this can't be reviewed in a single patch, so let's make this a meta.
Comment #3
markconroy commentedLooking through the instances of
ginin the core/themes/admin we have:I don't want to speak too soon, but _I think_ a simple find+replace would suffice from
gintoadminComment #5
markconroy commentedWe might get lucky with this one!
Comment #6
longwaveThis might just work!
We add
core/themes/admin/migration/css/base/admin.cssbut do not removecore/themes/admin/migration/css/base/gin.css, that needs fixing at least.Comment #7
markconroy commentedI was sure I renamed that file rather than duplicating it. It's removed now.
Comment #8
jurgenhaasWe also have the issue #3576646: Rename Gin-based admin theme which changes 629 files - well, that mainly because of renaming the
admindirectory todefault_adminwhich counts as a change for every contained file within that tree.I suspect we will get merge conflict when we do that other one and this one in either sequence.
But that also makes me wonder if we should really replace
ginwithadminor if we should also usedefault_adminfor e.g. class names and variables.I'd suggest, that we first get the other issue reviewed and merged, and then come back to this one, doing the Gin reference cleanup based on that. But the decision on whether to use admin or default_admin could already take place.
Comment #10
quietone commentedRebased this. And made a child issue just for comments.
Comment #11
poker10 commentedAdded two child issues which does not seems to be covered here.
Comment #12
poker10 commentedAdded another one.
Also this issue is affected by #3582826: Untangle gin.css, which already removed
core/themes/admin/migration/css/base/gin.css, but created approx. 90 new gin- named files (so the foldercore/themes/admin/migration/css/base/is now full of another gin- prefixed files). And also there iscore/themes/default_admin/templates/navigation/top-bar--gin.html.twig. So if we are going to rename files here as well, then we need to rename all of them.Moving to Needs work based on this. Thanks!
Comment #13
quietone commentedChanging to active while the work in the child issues is completed.
Comment #14
jurgenhaasThis remains the active tracking meta for removing inherited Gin references from the Default Admin theme.
Implementation is consolidated in #3605702: Remove remaining Gin and Claro implementation names from Default Admin theme, which now covers CSS/PCSS/generated CSS, JavaScript files and identifiers, behaviors, persisted browser state, settings, PHP, Twig, documentation, tests, accessibility, high contrast, VRT, compatibility, and the allowlist of legitimate Gin/Claro references.
#3576496: Remove references to Claro and #3611446: Migrate Gin CSS classes from default_admin twig overrides have been closed as duplicates after their requirements are transferred. MR!14967, !15233, and MR!16340 should remain reference inventories and be closed as superseded once the fresh #3605702: Remove remaining Gin and Claro implementation names from Default Admin theme MR exists. This meta remains open to track completion and any scoped follow-ups. Preserve contributor credit in the replacement work.
Comment #15
mherchelClosing this as outdated from #3605702: Remove remaining Gin and Claro implementation names from Default Admin theme
Comment #17
poker10 commentedThis is a meta issue. I think we should mark this fixed and assign credits once the last child issue #3584301: Update documentation for Default admin theme is done - and it seems like it is pretty much done. What do you think?
Comment #18
quietone commentedI agree with @poker10. Credit is also given for closed issues. I don't recall the date of that decision.
Comment #19
smustgrave commentedUpdated credit here.