Problem/Motivation

Waiting on #3575254: Module deprecation removal part2 and may wait for migrations to be removed.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#20 3575461-nr-bot_dyictchj.txt91 bytesneeds-review-queue-bot

Issue fork drupal-3575461

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

smustgrave opened merge request !15176

nicxvan’s picture

nicxvan commented

Honestly I think this should be postponed until right before alpha.

smustgrave’s picture

smustgrave commented

Sorry for the delay. Yes I’m holding this until alpha to get all the ones we missed or added after.

smustgrave closed merge request !15176

smustgrave opened merge request !15656

smustgrave’s picture

smustgrave commented

So this list has actually started to get pretty large wonder if we should just get a chunk in now vs a several 100 file MR later

smustgrave’s picture

smustgrave commented
Title: Cleanup any remainder deprecations from modules » Cleanup any remainder deprecations

smustgrave opened merge request !17052

quietone’s picture

quietone commented

I applied the diff and did limited searching.

$ git grep -l 'removed from drupal:12.0.0'
composer/Generator/Builder/DrupalPinnedDevDependenciesBuilder.php
core/misc/ajax.js
core/modules/language/language.module
core/tests/Drupal/KernelTests/Core/ClassLoader/BackwardsCompatibilityClassLoaderTest.php
core/tests/Drupal/Tests/DrupalTestCaseTrait.php
core/tests/fixtures/TestTools/drupal_debug_classloader_test_classes.php

$ git grep -l 'removed from drupal:12.0.0';git grep -l 'removed in drupal:12.0.0'
composer/Generator/Builder/DrupalPinnedDevDependenciesBuilder.php
core/misc/ajax.js
core/modules/language/language.module
core/tests/Drupal/KernelTests/Core/ClassLoader/BackwardsCompatibilityClassLoaderTest.php
core/tests/Drupal/Tests/DrupalTestCaseTrait.php
core/tests/fixtures/TestTools/drupal_debug_classloader_test_classes.php
core/modules/system/tests/modules/router_test_directory/router_test.routing.yml
core/modules/system/tests/src/Functional/Routing/RouterTest.php
smustgrave’s picture

smustgrave commented
Status: Postponed » Needs review
dcam’s picture

dcam commented
Status: Needs review » Needs work

I think that the deprecation versions in core/misc/ajax.js should be updated. They were updated from 10 to 12 by #3464581: Update deprecation notices in ajax.js because #3352549: Remove deprecations in ajax.js hadn't been fixed yet. It still hasn't been fixed. Updating them now will prevent us from needing to have this conversation again later when someone greps Core for D12 deprecations again. So I'm setting the status to Needs Work.

It also looks like the BC layer for SYMFONY_DEPRECATIONS_HELPER should be removed. Was there a reason why you omitted it?

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

I missed SYMFONY_DEPRECATIONS_HELPER

For the ajax one I'm still trying to get an answer if we can skip it or not since HTMX is the end goal.

nicxvan’s picture

nicxvan commented

All of the .module conversations are in so a rebase might be worth it too.

smustgrave’s picture

smustgrave commented

Rebased

mondrake’s picture

mondrake
Location 🇮🇹
commented
Related issues: +#3574681: [Nov 2026] Introduce support for PHPUnit 13.5

SYMFONY_DEPRECATION_HELPER could be done in #3574681: [Nov 2026] Introduce support for PHPUnit 13.5 if it can wait. The MR there is already doing the removal.

nicxvan’s picture

nicxvan commented
Title: Cleanup any remainder deprecations » Cleanup any remaining deprecations
smustgrave’s picture

smustgrave commented

@mondrake I'm happy to revert but what I removed didn't break if that matters.

mondrake’s picture

mondrake
Location 🇮🇹
commented

Dunno. For core I do not see a problem, it's rather contrib: if they (we :)) start testing against next major and the deprecated variable is already removed, they may find a barrier as they'll have to fix the testing itself first.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3575461-nr-bot_dyictchj.txt91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Needs work

Left a handful of comments on the MR.

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

Hoping to get this in before beta

nicxvan’s picture

nicxvan commented
Status: Needs review » Reviewed & tested by the community

This looks ready!

I pulled it down and the only remaining 12 is the ajax one which has a follow up.

As far as I can tell the theme-settings is the only tricky removal and that looks correct!

SYMFONY_DEPRECATION_HELPER seems fine here, we can always add it back if contrib has issues.

godotislate’s picture

godotislate
he/him
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs followup

One comment. Also a follow up needed for DI.

godotislate’s picture

godotislate
he/him
commented
Issue tags: -Needs followup
dcam’s picture

dcam commented
Status: Needs work » Reviewed & tested by the community

All feedback has been addressed.

nicxvan’s picture

nicxvan commented
Related issues: +#3623051: Clean up references to moved Search plugins

Here is the followup: #3623051: Clean up references to moved Search plugins

  • catch committed 4371e3ce on main 
    task: #3575461 Cleanup any remaining deprecations

By: smustgrave
By:...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.