Problem/Motivation

#3566600: Deprecate drupal/core-dev-pinned metapackage and #3575461: Cleanup any remaining deprecations removed updates of the PinnedDevDependencies metapackage, but left the stale composer.json in as well as did not adjust EnsurePHPStanVersionsMatchTest.

This is causing packaging issues and test failures of the PHPStan rules.

Steps to reproduce

Composer update phpstan and see failures in PHPStan rule tests.

Proposed resolution

Remove the stale composer.json and adjust the test.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3631365

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

mondrake created an issue. See original summary.

mondrake’s picture

Assigned: mondrake » Unassigned
Status: Active » Needs review
mondrake’s picture

godotislate’s picture

This looks right, but I'm not sure how this affects the subtree pushes. Presumably it should be correct to stop pushing them for 12.x? Somehow the https://github.com/drupal/core-dev-pinned repo has a 12.0.0-beta2 from three weeks ago, https://github.com/drupal/core-dev-pinned/releases/tag/12.0.0-beta2, even though the core release was yesterday.

mondrake’s picture

More cleanup.

longwave’s picture

Status: Needs review » Needs work

The subtree splitter runs during the packaging process and as I understand it should just ignore this package as soon as we remove it from core. Only the DA have access to packaging logs so the only real way to find out is commit and see what happens.

One question on the MR.

xjm’s picture

@drumm located the code that would need to be cbanged in packaging:
https://gitlab.com/drupal-infrastructure/subtree-splitter/-/blob/e0d13fe...