#3432874: Replace "Expose all fields as blocks to Layout Builder" configuration with a feature flag module introduced the layout_builder_expose_all_field_blocks flag module. It needs to be marked obsolete so it can be removed.
None.
The Layout Builder Expose All Field Blocks module that was previously deprecated is now obsolete and will be uninstalled on sites automatically in an update.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | full-removal.patch | 6.97 KB | gábor hojtsy |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
catchIt can only be marked obsolete in 12.x. The module has to be uninstalled, before it can be removed, we can only guarantee it's been uninstalled when the hook_update_N() to uninstall it has definitely run - that update hook even if it's added in 11.x is only required to run to get to 12.x. See https://www.drupal.org/about/core/policies/core-change-policies/how-to-d...
Comment #3
smustgrave commentedThanks for clarifying, cleaned up the IS
Comment #6
ishani patel commentedComment #7
ishani patel commentedHello,
I've raised MR for the above changes.
Kindly please review it.
Thanks!
Comment #8
smustgrave commentedCaused some test failures.
Comment #9
danielvezaDo we also delete any of the code in Layout Builder that references this flag module as part of this issue?
E.G. in
LayoutBuilderEntityViewDisplay::saveComment #10
catch@danielveza yes we should do that.
Bumping this to major and a 12.0.0 beta blocker.
Comment #12
gábor hojtsySo it was introduced in #3432874: Replace "Expose all fields as blocks to Layout Builder" configuration with a feature flag module to make it easier to remove it. I made an (LLM assisted) attempt to remove the related code. I am not yet pushing this to the MR because if we are not removing the module we should not remove integrations with it either, no? Let's look at this patch first to discuss what exactly should be in the MR.
ddev exec "./vendor/bin/phpunit --configuration core/phpunit.xml.dist core/modules/layout_builder/tests/src/Kernel/passes fine with this. But the tests otherwise don't like enabling obsolete modules, if we keep them in the integrations and tests, which is what the MR is currently failing ;)Comment #13
gábor hojtsyComment #14
gábor hojtsyI think this is complete and ready for review. Only the info file remains of the module, integration code from layout builder was removed. Updated issue summary and added release note snippet.
Comment #15
smustgrave commentedBased on how migrate_drupal was done this looks like a good deprecation/obsolete mark. Glad to see it go :)
Comment #17
longwaveLooks good to me too.
Committed and pushed 9fc95e06f27 to main. Thanks!
Comment #20
quietone commented