Problem/Motivation

layout_builder_expose_all_field_blocks needs to be marked obsolete so it can be removed

Steps to reproduce

Proposed resolution

In main mark it obsolete

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3573879

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented

It can only be marked obsolete in 12.x. The module has to be uninstalled, before it can be removed, we can only guarantee it's been uninstalled when the hook_update_N() to uninstall it has definitely run - that update hook even if it's added in 11.x is only required to run to get to 12.x. See https://www.drupal.org/about/core/policies/core-change-policies/how-to-d...

smustgrave’s picture

smustgrave commented
Title: Mark layout_builder_expose_all_field_blocks obsolete and remove » Mark layout_builder_expose_all_field_blocks obsolete
Issue summary: View changes

Thanks for clarifying, cleaned up the IS

ishani patel made their first commit to this issue’s fork.

ishani patel opened merge request !14789

ishani patel’s picture

ishani patel commented
Assigned: Unassigned » ishani patel
ishani patel’s picture

ishani patel commented
Assigned: ishani patel » Unassigned
Status: Active » Needs review

Hello,
I've raised MR for the above changes.

Kindly please review it.

Thanks!

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Caused some test failures.

danielveza’s picture

danielveza
he/him
Location Brisbane, AU
commented

Do we also delete any of the code in Layout Builder that references this flag module as part of this issue?

E.G. in LayoutBuilderEntityViewDisplay::save