Problem/Motivation

#3432874: Replace "Expose all fields as blocks to Layout Builder" configuration with a feature flag module introduced the layout_builder_expose_all_field_blocks flag module. It needs to be marked obsolete so it can be removed.

Steps to reproduce

Proposed resolution

  • Mark the module obsolete.
  • Remove generic test (same as other obsolete modules).
  • Remove help hook since it cannot be enabled anymore.
  • Remove integration code and integration tests from layout builder.
  • Adjust JS test to manually turn on the field being tested.

Remaining tasks

None.

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

The Layout Builder Expose All Field Blocks module that was previously deprecated is now obsolete and will be uninstalled on sites automatically in an update.

CommentFileSizeAuthor
#12 full-removal.patch6.97 KBgábor hojtsy

Issue fork drupal-3573879

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented

It can only be marked obsolete in 12.x. The module has to be uninstalled, before it can be removed, we can only guarantee it's been uninstalled when the hook_update_N() to uninstall it has definitely run - that update hook even if it's added in 11.x is only required to run to get to 12.x. See https://www.drupal.org/about/core/policies/core-change-policies/how-to-d...

smustgrave’s picture

smustgrave commented
Title: Mark layout_builder_expose_all_field_blocks obsolete and remove » Mark layout_builder_expose_all_field_blocks obsolete
Issue summary: View changes

Thanks for clarifying, cleaned up the IS

ishani patel made their first commit to this issue’s fork.

ishani patel opened merge request !14789

ishani patel’s picture

ishani patel commented
Assigned: Unassigned » ishani patel
ishani patel’s picture

ishani patel commented
Assigned: ishani patel » Unassigned
Status: Active » Needs review

Hello,
I've raised MR for the above changes.

Kindly please review it.

Thanks!

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Caused some test failures.

danielveza’s picture

danielveza
he/him
Location Brisbane, AU
commented

Do we also delete any of the code in Layout Builder that references this flag module as part of this issue?

E.G. in LayoutBuilderEntityViewDisplay::save

catch’s picture

catch
he/him
Primary language English
commented
Priority: Normal » Major
Issue tags: +12.0.0 beta blocker

@danielveza yes we should do that.

Bumping this to major and a 12.0.0 beta blocker.

gábor hojtsy made their first commit to this issue’s fork.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue summary: View changes
StatusFileSize
new full-removal.patch6.97 KB

So it was introduced in #3432874: Replace "Expose all fields as blocks to Layout Builder" configuration with a feature flag module to make it easier to remove it. I made an (LLM assisted) attempt to remove the related code. I am not yet pushing this to the MR because if we are not removing the module we should not remove integrations with it either, no? Let's look at this patch first to discuss what exactly should be in the MR.

ddev exec "./vendor/bin/phpunit --configuration core/phpunit.xml.dist core/modules/layout_builder/tests/src/Kernel/ passes fine with this. But the tests otherwise don't like enabling obsolete modules, if we keep them in the integrations and tests, which is what the MR is currently failing ;)

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Mark layout_builder_expose_all_field_blocks obsolete » Mark layout_builder_expose_all_field_blocks obsolete, uninstall it and remove integration code
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue summary: View changes
Status: Needs work » Needs review

I think this is complete and ready for review. Only the info file remains of the module, integration code from layout builder was removed. Updated issue summary and added release note snippet.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Based on how migrate_drupal was done this looks like a good deprecation/obsolete mark. Glad to see it go :)

  • longwave committed 9fc95e06 on main 
    task: #3573879 Mark layout_builder_expose_all_field_blocks obsolete,...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Looks good to me too.

Committed and pushed 9fc95e06f27 to main. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

longwave closed merge request !14789

quietone’s picture

quietone commented
Issue tags: +12.0.0 release notes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.