Problem/Motivation

When installing a clean Drupal 11 on PHP 8.3 and saving the settings with incorrect info, the next error is thrown:

Deprecated function: Calling get_class() without arguments is deprecated in Drupal\cloudflare_stream\Service\CloudflareStreamApi->handleError() (line 328 of /var/www/html/src/Service/CloudflareStreamApi.php)

Steps to reproduce

  1. Install a Drupal 11 with standard install profile
  2. Install the module and save its settings
  3. Try adding a field to an entity

Proposed resolution

Fix the error

Remaining tasks

Fix the error

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Issue fork cloudflare_stream-3565043

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tim-diels created an issue. See original summary.

garvitasakhrani made their first commit to this issue’s fork.

garvitasakhrani’s picture

garvitasakhrani commented

Fixed PHP 8.3/8.4 deprecation warnings in CloudflareStreamApi.
Changes have been pushed to the issue fork branch 3565043-deprecated-function-calling.
Please review.

garvitasakhrani’s picture

garvitasakhrani commented
Status: Active » Needs review
tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Status: Needs review » Needs work

Please create a MR from your branch so this can be reviewed. Without MR this is not possible. Please see https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr...

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Status: Needs work » Active

garvitasakhrani opened merge request !43

garvitasakhrani’s picture

garvitasakhrani commented
Status: Active » Needs review
tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Status: Needs review » Needs work

Please only do what is requested in this issue. You also tried to fix coding standards but didn't do all of them.
So I gonna revert the CS changes.

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Status: Needs work » Needs review

Reverted the CS changes.

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Tested and error is gone now.

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.