Problem/Motivation

Contact module is being deprecated. Usages is tests not in Contact needs to removed and test coverage moved to the Contact module.

Steps to reproduce

Proposed resolution

Use a test module instead of Contact in core/tests/Drupal/KernelTests/Core/Entity/ContentEntityNullStorageTest.php

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3556693

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#2337753: ContentEntityNullStorage does not implement a query service, +#2487588: Move CMI import/export directory "staging" to "sync", as it is confused with staging environments
andypost’s picture

andypost
he/him
Primary language Russian
commented

Looks like it needs new config and content entities to replicate the test

andypost opened merge request !13742

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review

Used to introduce new config entity to mimic Contact form

smustgrave’s picture

smustgrave commented

Should this be expanded to cover the other 2 tests in the core/tests folder using contact?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Lets keep this focused on this test. Changes make sense.

The bundle deleting test seems a little but strange, that doesn't really test that validator, that doesn't care about null storage, it just indirectly tests the getQuery() implementation of the null storage, which I guess doesn't hurt. maybe there was a specific bug there in the past.

There are already other issues in the meta issue for the dialog/ajax test, I think we might be missing one for ExtensionAvailableConstraintValidatorTest.php.

catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed 137b3fe2 on 11.3.x 
    task: #3556693 Change use of Contact in ContentEntityNullStorageTest

By...

  • catch committed ad1cf48b on 11.x 
    task: #3556693 Change use of Contact in ContentEntityNullStorageTest

By...

catch closed merge request !13742

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

FYI this broke HEAD on DER - #3570942: Failing update path tests in HEAD because the new entity type doesn't exist in our tests dumps that use entity_test module - I guess that's on us for using entity_test for our update tests