Problem/Motivation

Track the steps needed to deprecate extension Contact module. See Remove a core module and move it to a contributed project of the deprecation policy.

The removal of extension Contact module was approved in #3476879: [Policy] Move Contact module to contrib.

Remaining tasks

  1. Begin finding someone to maintain the contrib version of the extension.
  2. Move integrations implemented by other modules to the extension.
    Create child issues or child meta issues, as needed, to address the following points. Not all points will apply to all extensions.
  3. Do a thorough search of core for any remaining references to the extension. If references are found, outside of the extension, then create issues to remove the references.
  4. Create the contrib project with a stable release, before the alpha version of the major release. Follow the process in Create the contrib project with a stable release for creating the sub tree split.
  5. Deprecate the core extension. #3520470: Deprecate the Contact module.
  6. #3567856: Ensure that Contact does not get special core treatment

Issue fork drupal-3520460

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue tags: +11.2.0 release priority

Happy to maintain it in contrib

andypost’s picture

andypost
he/him
Primary language Russian
commented

+1 to step in as co-maintainer

andypost’s picture

andypost
he/him
Primary language Russian
commented

Asked in slack access to the module https://drupal.slack.com/archives/C1BMUQ9U6/p1745586623875969

andypost’s picture

andypost
he/him
Primary language Russian
commented

Filed child #3521198: Offering to maintain Contact

thejimbirch’s picture

thejimbirch commented
Issue summary: View changes

Core's standard recipes have references to the Contact module in addition to the standard profile.

I updated the issue summary. Did the list of tasks come from a template? If so, we should update that also as recipes probably did not exist at the time that list of things to do was generated.

jamesoakley’s picture

jamesoakley
Primary language English
Location North Yorkshire, UK
commented

Somewhere after

4. Create the contrib project with a stable release

should there be a step to find all issues in the Core issue queue that relate to the Contact core module, and move them to the contrib project (presumably with a brief comment explaining). Any issues would need fixing in contrib first, with optional backport to the core version.

(I came here from #1997692: Create contact form block, which is one example)

quietone’s picture

quietone commented

@jamesoakley, the tasks in this issue include marking the issues for the Contact module as postponed, with a message. The task to move them to the contrib project is part of the tasks to remove the module from core, which is worked on after the 12.x branch is open.

A search of core issue for issues that should be in the 'contact.module' is not done. It is assumed that issues have been triaged correctly.

andypost’s picture

andypost
he/him
Primary language Russian
commented

Moved the issue to gain access #3521198-2: Offering to maintain Contact

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue tags: -11.2.0 release priority +11.3.0 release priority
andypost’s picture

andypost
he/him
Primary language Russian
commented

asked again #3521198-6: Offering to maintain Contact

quietone’s picture

quietone commented

Searching for tests and found these

  1. core/modules/config_translation/tests/src/Functional/ConfigTranslationCacheTest.php
  2. core/modules/config_translation/tests/src/Functional/ConfigTranslationListUiTest.php
  3. core/modules/config_translation/tests/src/Functional/ConfigTranslationOverviewTest.php
  4. core/modules/config_translation/tests/src/Functional/ConfigTranslationUiTestBase.php
  5. core/modules/locale/tests/src/Functional/LocaleConfigTranslationTest.php
  6. core/modules/system/tests/src/Functional/UpdateSystem/UpdatePathTestBaseFilledTest.php
  7. core/modules/user/tests/src/Functional/UserPermissionsTest.php
  8. core/modules/views/tests/src/Kernel/Handler/HandlerAllTest.php
  9. core/modules/views/tests/src/Kernel/TestViewsTest.php
  10. core/tests/Drupal/FunctionalJavascriptTests/Ajax/DialogTest.php
  11. core/tests/Drupal/KernelTests/Core/Entity/ContentEntityNullStorageTest.php

plus

  1. core/modules/migrate_drupal_ui/tests/src/Functional/d7/NoMultilingualReviewPageTest.php
  2. core/modules/migrate_drupal_ui/tests/src/Functional/d7/NoMultilingualReviewPageTest.php
  3. core/modules/migrate_drupal_ui/tests/src/Functional/d7/MultilingualReviewPageTest.php
  4. core/modules/migrate_drupal_ui/tests/src/Functional/d7/MultilingualReviewPageTest.php
  5. core/modules/migrate_drupal_ui/tests/src/Functional/d7/Upgrade7Test.php
  6. core/modules/migrate_drupal_ui/tests/src/Functional/d6/NoMultilingualReviewPageTest.php
  7. core/modules/migrate_drupal_ui/tests/src/Functional/d6/MultilingualReviewPageTest.php
  8. core/modules/migrate_drupal_ui/tests/src/Functional/d6/Upgrade6Test.php
quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Issue summary: View changes
zviryatko’s picture

zviryatko commented
Issue summary: View changes
andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue tags: +Vienna2025

discussed with @xjm at Drupalcon and priority to clean-up standard profile and tests first for 11.3 and it's ok to do deprecation in 11.4/12

andypost’s picture

andypost
he/him
Primary language Russian
commented

removal from standard profile is done!

andypost’s picture

andypost
he/him
Primary language Russian
commented

removed from umami

now
- #3551599: Remove use of Contact from config_translation tests
- #3551376: Move mention of Contact from core help to contact module
- recipe and migrations

andypost’s picture

andypost
he/him
Primary language Russian
commented
Category: Task » Plan
quietone’s picture

quietone commented
Issue summary: View changes
andypost’s picture

andypost
he/him
Primary language Russian
commented

one more commited #3551599: Remove use of Contact from config_translation tests

zviryatko’s picture

zviryatko commented

@quietone, I've also checked for contact form usage in tests, here are some additional findings:

core/tests/Drupal/Nightwatch/Tests/Olivero/oliveroPreprocessFieldMultipleValueFormTest.js:17
permissions: ['access site-wide contact form'],

core/profiles/tests/nightwatch_a11y_testing/config/install/user.role.anonymous.yml:19
- 'access site-wide contact form'

core/modules/user/tests/src/Kernel/Migrate/d7/MigrateUserRoleTest.php:144
'access site-wide contact form',

core/modules/system/tests/modules/ajax_test/src/Controller/AjaxTestController.php:303
'url' => Url::fromRoute('contact.form_add'),

core/lib/Drupal/Core/Config/Schema/SchemaCheckTrait.php:55
'contact.settings' => [

quietone’s picture

quietone commented

@zviryatko, thanks for looking for more instances.

I only have time for some simple searching and this is what I think needs to happen.

quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Issue summary: View changes
andypost’s picture

andypost
he/him
Primary language Russian
commented

Filed test change for #3555375-4: Change use of Contact in \Drupal\Tests\user\Functional\UserPermissionsTest::testAccessBundlePermission

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue summary: View changes
andypost’s picture

andypost
he/him
Primary language Russian
commented

So only ContentEntityNullStorageTest left with dumps!

Created MR #3556693: Change use of Contact in ContentEntityNullStorageTest

rmahi_14 made their first commit to this issue’s fork.

quietone’s picture

quietone commented

@rmahi_14, thanks for the interest in this issue. However, this issue does not need an issue fork. I suggest you consult the Drupal Contributor Guide to find a task suited to your interests and skills.

quietone’s picture

quietone commented
Issue summary: View changes

Moved the info from #23 to the issue. At least 3 more issues are needed.

quietone’s picture

quietone commented
Issue summary: View changes
andypost’s picture

andypost
he/him
Primary language Russian
commented

There's one more in ExtensionAvailableConstraintValidatorTest.php pointed in #3556693-7: Change use of Contact in ContentEntityNullStorageTest

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue summary: View changes

Filed #3557138: Remove use of Contact from ExtensionAvailableConstraintValidatorTest

quietone’s picture

quietone commented
Issue summary: View changes

Reviewing the list in #12
1, 2, 3, 4: Fixed in #3551599: Remove use of Contact from config_translation tests
5: Todo, core/modules/system/tests/src/Functional/UpdateSystem/UpdatePathTestBaseFilledTest.php
7: #3555375: Change use of Contact in \Drupal\Tests\user\Functional\UserPermissionsTest::testAccessBundlePermission
8, 9: #3554484: Remove unused modules from kernel tests
10: Will likely be fixed in #3557103: Change use of Contact in ajax_test test module; core/tests/Drupal/FunctionalJavascriptTests/Ajax/DialogTest.php
11: #3556693: Change use of Contact in ContentEntityNullStorageTest

thejimbirch’s picture

thejimbirch commented

Is there a #6? Or was the number just skipped?

quietone’s picture

quietone commented
Issue tags: -11.3.0 release priority +11.4.0 release priority
quietone’s picture

quietone commented
Issue summary: View changes

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

andypost’s picture

andypost
he/him
Primary language Russian
commented

As I see only leftover is #3557103: Change use of Contact in ajax_test test module

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented

#3557103: Change use of Contact in ajax_test test module was merged today. There's still #3557105: Change use of Contact in SchemaCheckTrait but apparently not a blocker.

andypost’s picture

andypost
he/him
Primary language Russian
commented

Yes, not a blocker so I'm gonna start split it to contrib this weekend

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review

Contrib release created https://www.drupal.org/project/contact/releases/1.0.0

xmacinfo’s picture

xmacinfo
he/him
Primary language French
Location Canada
commented

Thank you.

andypost’s picture

andypost
he/him
Primary language Russian
commented

Added section to https://www.drupal.org/docs/core-modules-and-themes/deprecated-and-obsol...

godotislate’s picture

godotislate
he/him
commented

Re #23:

core/tests/Drupal/Nightwatch/Tests/Olivero/oliveroPreprocessFieldMultipleValueFormTest.js:17 - this test is using a test module so there is no change needed.

The test module olivero_test has a dependency on drupal:contact and has core/modules/system/tests/modules/olivero_test/config/install/contact.form.olivero_test_contact_form.yml. Does this need a removal or change?

andypost’s picture

andypost
he/him
Primary language Russian
commented

@godoislate Thank you! looks like it needs one more issue to remove it before the module removal, looks like it can stay as is like consensus to not change trait in #3557105: Change use of Contact in SchemaCheckTrait

andypost’s picture

andypost
he/him
Primary language Russian
commented

module is deprecated! now it's time to remove it from main!

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Re #46 I addressed it in removal replacing contact with node module #3573484: Remove Contact module from core

quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Fixed

I think we are all done here. There is an issue for SchemaCheckTrait and Update fixtures will be finalized in one issue.

Thanks everyone for keeping this meta updated, it really helps us all.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.