Problem/Motivation

Contact module is being deprecated. Usages is tests not in Contact needs to removed and test coverage moved to the Contact module.

Steps to reproduce

Proposed resolution

Use a test module instead of Contact in \Drupal\Tests\user\Functional\UserPermissionsTest::testAccessBundlePermission

Remaining tasks

MR

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3555375

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

andypost made their first commit to this issue’s fork.

andypost opened merge request !13717

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review

I found no testing config entity with canonical route so changed test to use comment module

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

I'm actually not that familiar with the Comment module, so I had to double-check that there are no bundle-related permissions. There aren't. Using Comment here seems like a good, straightforward replacement. And the test is still passing. This looks good to me.

dcam’s picture

dcam commented

I just noticed #1903138: Move global comment permissions to comment-type level which if implemented would cause this test to need to be updated again. I don't think a 12-year-old issue that isn't approaching a resolution should hold up this task that's necessary for getting Contact out of Core. But it does need to be mentioned.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#1903138: Move global comment permissions to comment-type level

Thank you, better to link'em

  • catch committed 23eb4f86 on 11.3.x 
    Issue #3555375 by quietone, andypost, dcam: Change use of Contact in \...

  • catch committed ca1bb67e on 11.x 
    Issue #3555375 by quietone, andypost, dcam: Change use of Contact in \...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Yes would be slightly better to move to one of the entity_test modules here if there is one that just works, but also OK to defer that until comment module changes something.

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !13717

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.