Problem/Motivation

Contact is being deprecated, see the parent issue for details. This issue is for removing the 'Website feedback contact form' recipe from the standard profile.

Steps to reproduce

Proposed resolution

Remove the 'feedback_contact_form' recipe from the core.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3553006

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

zviryatko created an issue. See original summary.

thejimbirch made their first commit to this issue’s fork.

thejimbirch opened merge request !13542

thejimbirch’s picture

thejimbirch commented
Status: Active » Needs review

Deleted the recipe and removed it from being applied from the standard recipe. Lets see what happens to the tests.

andypost’s picture

andypost
he/him
Primary language Russian
commented

It needs trick to replace Input's test 

  Input (Drupal\KernelTests\Core\Recipe\Input)
     ✘ Default value from config
       ┐
       ├ Drupal\Core\Recipe\RecipeFileException: There is no /builds/issue/drupal-3553006/core/recipes/feedback_contact_form/recipe.yml file
       │
       │ /builds/issue/drupal-3553006/core/lib/Drupal/Core/Recipe/Recipe.php:115
       │ /builds/issue/drupal-3553006/core/lib/Drupal/Core/Recipe/Recipe.php:90
       │ /builds/issue/drupal-3553006/core/tests/Drupal/KernelTests/Core/Recipe/InputTest.php:66
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Needs work
quietone’s picture

quietone commented
Title: Remove Contact module recipe from core » Remove Contact recipe
quietone’s picture

quietone commented
Status: Needs work » Needs review

Rebased and tests passing now.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems like a good removal, not sure what else to verify. Not sure if anyone wants to turn this into a contrib recipe?

thejimbirch’s picture

thejimbirch commented

That is a good idea since it is a really good example of recipe input.

I'll set it up. If anyone wants to be a maintainer, let me know.

smustgrave’s picture

smustgrave commented

Would ask the maintainer of contact if they want to. But if no one volunteers I don’t mind helping

thejimbirch’s picture

thejimbirch commented

You've been added.

  • catch committed 7e34b3bb on 11.3.x 
    Issue #3553006 by thejimbirch, andypost, quietone, smustgrave: Remove...

  • catch committed 1bd3c333 on 11.x 
    Issue #3553006 by thejimbirch, andypost, quietone, smustgrave: Remove...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !13542

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.