Problem/Motivation

Some of the arguments are defined as not required, however their types are declared are string or int rather than ?string and ?int which causes the validation to fail when the non-required argument is omitted.

Steps to reproduce

Following the changes made in #3552848: The rotate operation doesn't work when applied on an image , the Rotate operation fails when the background is omitted because the type doesn't match what was expected.

Proposed resolution

Update the schema for all non-required arguments so they include the ? prefix on their types.

Remaining tasks

Provide issue fork.

Issue fork image_effects-3552856

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

codebymikey created an issue. See original summary.

codebymikey opened merge request !78

codebymikey’s picture

codebymikey commented
Issue summary: View changes
Status: Active » Needs review
mondrake’s picture

mondrake
Location 🇮🇹
commented
Version: 4.1.x-dev » 5.0.x-dev

I see the MR already targets 5.0.x, thanks

mondrake’s picture

mondrake
Location 🇮🇹
commented

Committed to 5.0.x and cherry-picked to 4.0.x

Not cherry-picked to 4.1.x because there is not likely going to be a release 4.1.0 ever, for the same reason of #3549711: Stable release imagemagick 4.1.0.

Thanks!

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.