Postponed (maintainer needs more info)
Project:
Drupal Canvas
Version:
1.x-dev
Component:
Page builder
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
26 Jun 2025 at 13:58 UTC
Updated:
29 Aug 2025 at 13:24 UTC
Jump to comment: Most recent, Most recent file


Comments
Comment #2
wim leersThanks, interesting edge case! 😄
Comment #3
wim leersSimilar symptoms as #3509333: After an error it’s possible to get trapped in an unrecoverable error state!
Comment #4
mayur-sose commentedComment #6
bnjmnmComment #8
bnjmnmComment #11
larowlanNeat approach. Can we get a kernel test added for the authentication checker?
Comment #12
bnjmnmYep,! There's a bunch of other tests that need updating too - I just didn't want to do all that refactoring until I got a +1 but now that I have one I'll hop on that.
Comment #13
bnjmnmComment #14
wim leersLooking good! Missing some cacheability bits — provided pointers to prior art.
Two tests are failing:
testAuthenticationRequiredPermission()(👍) — it identified one route definition that still needs to be updatedComment #15
wim leersWould also be nice to get a GIF of this new UI functionality in action 😇
Comment #16
bnjmnmFailing test is just a flaky Playwright
Comment #17
wim leersReopened a thread, because I don't understand the answer: https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...
A mild concern about relying on https://developer.mozilla.org/en-US/docs/Web/HTTP/Guides/Authentication#... at https://git.drupalcode.org/project/experience_builder/-/merge_requests/1... — but I'm okay with merging as-is.
Just need to get clarity on that one thing 😇
Comment #18
wim leersAhhhhh!
That is why! Reverting my revert, and merging 👍
Comment #19
wim leersComment #20
wim leersManually tested, works well 👍
Comment #22
wim leers🎉
Comment #23
mayur-sose commentedAfter renaming the cookie and reloading the page, I am getting the following session timeout error:
{ "errors": [ "You must be logged in to access this resource." ] }Error 401: You must be logged in to access this resource.
And after clicking on the "Go to login" button, the page is correctly redirected to the login page. This behaviour is working as expected. Now, the page is not getting stuck on the error page.
Comment #24
lauriiiWe need to adjust the errors that are displayed to user in this situation. This isn't really an unexpected error.. This is just the users session timing out?
Comment #25
wim leersYeah, I was thinking that too — but this is such a massive improvement compared to where we were before that I didn't want to push back over this. 😅
Comment #26
lauriii+1 for landing the fix as it is but it would be great to plan for doing #24 too.
Comment #27
wim leersOkay — but what do you expect that to look like? We were flying blind here: empty proposed solution in the issue summary, no designs.
So: the hard part is done — now we just need to tweak it to no longer have this less-than-great UX 😊