After an error it’s possible to get trapped in an unrecoverable error state

What about errors in (more complex) code components? Is that intended to be handled here, too? (Previously identified this in #3485878-15: Server-rendered component instances should NEVER result in a user-facing error, should fall back to a meaningful error instead (+ log), but perhaps this issue is a better place to discuss it.)

#3499960: Generate path alias dynamically when editing landed, which is how this actually was pretty easy to trigger until recently 😅

I know @balintbrews is working to add hardening in multiple places, and some have already landed. @balintbrews, do you think that this issue can be marked as a duplicate of some other? 🤞

It's possible this is already at a state that's good enough for beta, but in case it isn't I'm tagging this as a beta blocker to make sure we evaluate it before releasing a beta.

I do not currently know of any remaining way to get to such a state. @mayur-sose, do you know of one?

@wim-leers, below is the one :

1. Create a new code component.
2. Add the component to the library and place it on the canvas.
3. Go to Layers, click on the three dots, and select Edit code.
4. After that, try to delete the component from Layers.
5. You will see the following error:

   An unexpected error has occurred in a route. 404 Not Found

Ah, that's the detail that was missing! We've already got an explicit bug report for that: #3530590: Expand functional test coverage for ContentCreatorVisibleXbConfigEntityAccessControlHandler.

Thanks, much appreciated!

Keeping this around to double-check after #3530590 lands that this indeed can be closed.

@mayur-sose You wrote "below is the one" — does that mean it's the only way you were able to get trapped? 🤞

I’m investigating whether there are any other situations where users can get trapped. I will update you if I find any.

Great, thanks! 🙏 I hope you'll fail, for all our sakes 😜😄

I can reproduce #8 and has nothing to do with the other issue mentioned in #9.

See my amend to #8:

1. Create a new code component.
2. Add the component to the library and place it on the canvas.
3. Go to Layers, click on the three dots, and select Edit code.
4. After that, try to delete ANY component from Layers.
   You will see the following error:

An unexpected error has occurred in a route. 404 Not Found

This happens even if I'm deleting something that is not what I'm seeing in the editor.
But surprisingly only happens if I have that component in the editor.

The difference is that if I create a new editor, my url is: xb_page/1/code-editor/code/test.
But if I edit a placed component code, my url is: xb_page/1/code-editor/component/jjj

(see component instead of code).

When I delete a component, even if it's not the one selected, i go from

xb/xb_page/1/editor/component/0b914052-f057-4a94-81db-bb64a09850e3 to xb/xb_page/1/editor (removing the component/{uuid}).

I think we are trying to do the same here, but ending in xb_page/1/code-editor which is a wrong url (you can just go directly in the browser and will see the same error Mayur indicated)

Maybe there's something checking a regex component/{whatever} without checking a) that whatever is a uuid or, b) that we are at /editor/component/{whatever} (ensuring no match with /code-editor/component/{whatever}

Per #13, unpostponing.

Related but more obscure way to get trapped: #3532618: [Needs design] After session times out, the XB UI is stuck.

We've made improvements to the error handling to avoid this from happening in more cases. Discussed with some of the XB folks that we will be opening issues for specific instances where this happens in case that we run into those in future.