Problem/Motivation

Editor Ribbon of CK Editor disappears when updated to Drupal 10.5. When the plugin is uninstalled it re-appears

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

thomas kaisuka created an issue. See original summary.

thomas kaisuka’s picture

StatusFileSize
new112.92 KB
rhayun’s picture

ckeditor5.js?sy999q:467 TypeError: Cannot read properties of undefined (reading 'check')
at new n (editorAdvancedImage.js?v=10.5.0:1:4237)
at d._createForm (editorAdvancedImage.js?v=10.5.0:1:6521)
at d.init (editorAdvancedImage.js?v=10.5.0:1:5951)

lisotton made their first commit to this issue’s fork.

lisotton’s picture

Status: Active » Needs review

I created a MR making it compatible with CKEditor 45.

paco11’s picture

I had the same issue. While waiting for a common solution, I simply disabled the module in the text format settings instead of fully uninstalling it.

lisotton’s picture

@paco11 have you tried to apply the patch from the MR?

paco11’s picture

I have not applied any patches, but simply switching to Drupal 10.5 ckeditor 5 and php 8.1.32 and php 8.3, still causes the same problem.

alienzed’s picture

Patch seems to work for me!

thomas kaisuka’s picture

@liston,

The patch does not work for both Drupal 10.5 and Drupal 11.2.1 that just came out a few hours ago.

joshuautley’s picture

Same issue here with Version: 3.0.1. Uninstalling the module allows the editor to reappear. Running Drupal 10.5.0 with PHP 8.3.22

cms_macgyver’s picture

Made changes from MR and rebuilt js/build/editorAdvancedImage.js

This fixed the error on 10.5.0, but I haven't tested on 11.2.x yet

paco11’s picture

Patch --> editorAdvancedImage.js

FROM:
this.saveButtonView = this._createButton(Drupal.t("Save"), t.icons.check, "ck-button-save", "save")
to:
this.saveButtonView = this._createButton(Drupal.t("Save"), null, "ck-button-save", "save")
FROM:
this.cancelButtonView = this._createButton(Drupal.t("Cancel"), t.icons.cancel, "ck-button-cancel", "cancel")
TO:
this.cancelButtonView = this._createButton(Drupal.t("Cancel"), null, "ck-button-cancel", "cancel"),

----------

FROM:
return o.set({
label: Drupal.t("Editor Advanced Image"),
icon: t.icons.threeVerticalDots,
tooltip: !0
TO
return o.set({
label: Drupal.t("Editor Advanced Image"),
icon: null, // ✅ rimuove l’icona ma evita l’errore
tooltip: true

It should solve everything

kwfinken’s picture

giordy’s picture

With Drupal 11.2 the CKEditor toolbar does not appear.

paco11’s picture

Solution #14 works for me width all version 10.5.1 and 11.2.2 and every browser

robbt’s picture

I have tested the patch at https://git.drupalcode.org/project/editor_advanced_image/-/merge_request... by @lisotton and it worked for 10.5 - I would make this RTBC but someone should check that it also works under D11 as #11 indicated there maybe a problem there.

This same issue applies to the 2.x branch as well as I had the 10.5 update break CKEditor 5 due to this bug.

thomas kaisuka’s picture

StatusFileSize
new216.2 KB

Problem fixed in 10.5 but still persistent in 11.2.2 unless i disable the balloon. i.e in relation to this patch: https://git.drupalcode.org/project/editor_advanced_image/-/merge_request...

wengerk’s picture

Thanks to all of you for contributing and fixing the module since last CK5 update.

I'll be back from holiday at the end of July - I would merge with please MR/Patch that passes all the tests in the meanwhile, otherwise I will work on it when I'm back to my computer :)

lisotton’s picture

I just tested the solution I provided in the MR with Drupal 11.2.2 and it is working fine.

  • lisotton committed bd6e6ba1 on 3.1.x
    #3530984: Compatibility with CKEditor 45 (Drupal 10.5)
    
wengerk’s picture

Status: Needs review » Fixed

Merged into 3.1.x as it needed to run on drupal 10.5 or 11.2 minimal - therefore keep the branch 3.0.x for below drupal 10.5/11.2
Thanks everyone for working on this fix !!

will be released with 3.1.0

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.