Problem/Motivation

Track the steps needed to remove extension Field Layout from core to contrib. See Remove a core module and move it to a contributed project of the deprecation policy.

The removal of extension Field Layout was approved in #3007167: [policy] Deprecate field_layout module and move it to contrib.

Remaining tasks

  1. Create a child issue, 'Remove Field Layout from core'.
    • ✅ The change record for this issue should include a link to recommendations page, https://www.drupal.org/node/3223395#s-field-layout. (For example, the CR for removing HAL)
    • Tag this issue 'Needs release note.'
    • Remove the extension ;-).
    • Update Update path tests as needed. See Writing Automated Update Tests for Drupal 8 (or later) for details.
    • Remove references from core/phpstan-baseline.neon.
    • Remove any spelling words specific to the extension from the dictionary
    • Add the extension to the relevant removed list, either DRUPAL_CORE_REMOVED_MODULE_LIST or DRUPAL_CORE_REMOVED_THEME_LIST, in system.install.
    • Check for references in @todo.
    • Handle migration tests.
      • In all the functional tests in migrate_drupal_ui make sure that Field Layout is not installed. EXTENSION_NAME should also be removed from the methods getAvailablePaths() and moved to getMissingPaths() in the tests using those methods.
  2. ✅ Deprecate the extension in the current minor development branch. If the next major branch is open, the extension can be removed via a separate patch (to avoid dependent patches), otherwise an issue should be opened to remove the extension once the next major branch is open.
  3. ✅ Open an issue, 'Ensure that Field Layout does not get special core treatment' in the packages.drupal.org issue queue to ensure that the composer namespace for the contributed project matches the core one after removal. This is to allocate the drupal/Field Layout Composer namespace to contrib extension rather than the core extension.
  4. ✅ Manually test upgrading from the core extension to the contrib extension. There is an issue template available for this.
  5. ✅ Triage core issues for Field Layout in the core queue and move either to the contrib project or the relevant core component. Restore the status to what it was before it was postponed. Also, is the issue moved to contrib, then move any change record.
  6. ✅ Move all core documentation for Field Layout to the contrib project. Make issues in the contrib project to update or add links to the documentation on the project page.
  7. ✅ When the issue in https://www.drupal.org/project/project_composer is Fixed update the documentation with the new Composer command.

Release notes snippet

CommentFileSizeAuthor
#16 FL.png14.47 KBandypost

Comments

quietone created an issue. See original summary.

quietone’s picture

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

andypost’s picture

Status: Postponed » Active
andypost’s picture

Status: Active » Reviewed & tested by the community

@quietone I think all done here! thank you for guidance

andypost’s picture

Status: Reviewed & tested by the community » Fixed

module removed and contrib works

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

quietone’s picture

Status: Fixed » Needs work

Thanks for confirming the contrib version works.

I came across this while checking the latest change records. The change records for this should link the to 'deprecated and obsolete extensions doc page. That is in step 1 with a link to an existing change record that can be mostly copy and pasted. I have updated the change record.

I also completed the documentation changes needed for step 7.

What of steps 4, 5 and 6? I can explore that more tomorrow, right now I am concentrating on change records.

andypost’s picture

Status: Needs work » Needs review

I bet all steps passed and step 7 as well as we had to create 2.0 as it was impossible to install

smustgrave’s picture

There appears to be a number of issues still under field_layout should those be moved over now?

andypost’s picture

Thank you! missed to check it(

andypost’s picture

Moved all issues

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Believe all steps are complete

quietone’s picture

Status: Reviewed & tested by the community » Needs work

Reviewing this I found that there is no documentation for the Field Layout module to me. If there is I could not find it.

I don't see confirmation that the manual testing in step 4 was done. Have I missed that?

andypost’s picture

Status: Needs work » Needs review
StatusFileSize
new14.47 KB

@quietone what do you mean with testing, I do use the module on my projects so I just added it via composer req drupal/field_layout and cleared cache then make sure site works and make sure admin/modules is using it

Field layout

quietone’s picture

Issue summary: View changes
Status: Needs review » Needs work

The manual testing is confirm that the update path works. The steps are documented as an issue summary, at https://www.drupal.org/about/core/policies/core-change-policies/how-to-d....

quietone’s picture

Title: [12.x] [meta] Tasks to remove Field Layout module » [meta] Tasks to remove Field Layout module
quietone’s picture

Issue summary: View changes
Status: Needs work » Fixed

Thanks folks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.