Problem/Motivation

The SMTP config form includes the following warning message:

Disabled fields are overridden in site-specific configuration file.

This can be confusing for users, because there may not be a site-specific configuration file, and there may not be any disabled fields.

Steps to reproduce

1. enable the SMTP module
2. go to /admin/config/system/smtp

Proposed resolution

Only output the message if any fields are disabled.

CommentFileSizeAuthor
#5 After Patch.png292.01 KBsandeep_k
#5 Before Patch.png248.52 KBsandeep_k

Issue fork smtp-3504674

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

malcomio created an issue. See original summary.

malcomio’s picture

malcomio commented
Related issues: +#2731283: Display configuration overrides in the settings form

Seems that this line was added in #2731283: Display configuration overrides in the settings form, but it's never had any conditional logic around it.

malcomio opened merge request !46

malcomio’s picture

malcomio commented
Status: Active » Needs review
sandeep_k’s picture

sandeep_k commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Before Patch.png248.52 KB
new After Patch.png292.01 KB

@malcomio, Tested the MR MR !46 mergeable on Drupal version- 10.3.1-dev. The patch was applied successfully and looks good to me.

Testing Steps:

  • Download the SMTP Authentication Support module.
  • Go to Extend- Install> SMTP Authentication Support module.
  • Go to /admin/config/system/smtp- Added before results.
  • Download the shared patch and Apply.
  • Go to /admin/config/system/smtp and Re-verify this.

Testing Results:
After applying the patch, the warning message is not appearing now. RTBC++

bluegeek9’s picture

bluegeek9 commented

This is similar to #2826189: "Disabled fields are overridden in site-specific configuration file" Warning but not identical.

bluegeek9’s picture

bluegeek9 commented

I ended up merging the similar issue. Your solution is also good. I am setting the status to fix so I can grant you credit.

//www.flaticon.com/free-icons/thank-you Thank you for your contribution! Your continued support makes this project sustainable.
There are multiple ways to show appreciation for the work contributed to this project including:
  • Triage issues and adding more context to existing issues.
  • Flagging SMTP as a favorite on the project page to help others discover it and show your support.

bluegeek9 closed merge request !46

bluegeek9’s picture

bluegeek9 commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.