The settings form gets the mutable configuration for displaying so if you override some of the configs in settings.php, this is never reflected in the form.
The immutable display should be used instead.

CommentFileSizeAuthor
#8 smtp-display-configuration-overrides-2731283-8.patch7.15 KBzviryatko
#6 smtp-display-configuration-overrides-2731283-6.patch7.16 KBzviryatko
#2 2731283-config-form.patch570 bytespcambra
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pcambra created an issue. See original summary.

pcambra’s picture

pcambra
he/him
Primary language Spanish
Location Asturies
CreditAttribution: pcambra as a volunteer commented
Status: Active » Needs review
FileSize
2731283-config-form.patch570 bytes
pazhyn’s picture

pazhyn CreditAttribution: pazhyn as a volunteer and at AnyforSoft, Drupal Ukraine Community commented
Status: Needs review » Needs work

Patch from #2 rewrites configs in SMTP module settings from getting them from settings.php
And it will override the settings in database so they will be exportable.
Configs in settings.php should be only for local instance and not exportable.

pazhyn’s picture

pazhyn CreditAttribution: pazhyn as a volunteer and at AnyforSoft, Drupal Ukraine Community commented
Issue tags: +DrupalCamp Kyiv
pazhyn’s picture

pazhyn CreditAttribution: pazhyn as a volunteer and at AnyforSoft, Drupal Ukraine Community commented
Issue tags: +CodeSprintUA
zviryatko’s picture

zviryatko CreditAttribution: zviryatko at AnyforSoft, Drupal Ukraine Community commented
FileSize
smtp-display-configuration-overrides-2731283-6.patch7.16 KB
zviryatko’s picture

zviryatko CreditAttribution: zviryatko at AnyforSoft, Drupal Ukraine Community commented
Status: Needs work » Needs review
zviryatko’s picture

zviryatko CreditAttribution: zviryatko at AnyforSoft, Drupal Ukraine Community commented
FileSize
smtp-display-configuration-overrides-2731283-8.patch7.15 KB
dpovshed’s picture

dpovshed CreditAttribution: dpovshed as a volunteer and at Drupal Ukraine Community commented
Status: Needs review » Reviewed & tested by the community

Patch rom #8 looks great! Reviewed and tested manually, RTBC

wundo’s picture

wundo CreditAttribution: wundo at Chuva Inc. for Chuva Inc. commented
wundo’s picture

wundo CreditAttribution: wundo at Chuva Inc. for Chuva Inc. commented
Assigned: Unassigned » wundo
wundo’s picture

wundo CreditAttribution: wundo at Chuva Inc. for Chuva Inc. commented
Category: Task » Bug report

  • wundo committed f8f17bd on 8.x-1.x authored by zviryatko 
    Issue #2731283 by zviryatko, pcambra, wundo, pazhyn, dpovshed: Display...
wundo’s picture

wundo CreditAttribution: wundo at Chuva Inc. for Chuva Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.