The settings form gets the mutable configuration for displaying so if you override some of the configs in settings.php, this is never reflected in the form.
The immutable display should be used instead.

CommentFileSizeAuthor
#8 smtp-display-configuration-overrides-2731283-8.patch7.15 KBzviryatko
#6 smtp-display-configuration-overrides-2731283-6.patch7.16 KBzviryatko
#2 2731283-config-form.patch570 bytespcambra

Comments

pcambra created an issue. See original summary.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Active » Needs review
StatusFileSize
new 2731283-config-form.patch570 bytes
pazhyn’s picture

pazhyn commented
Status: Needs review » Needs work

Patch from #2 rewrites configs in SMTP module settings from getting them from settings.php
And it will override the settings in database so they will be exportable.
Configs in settings.php should be only for local instance and not exportable.

pazhyn’s picture

pazhyn commented
Issue tags: +DrupalCamp Kyiv
pazhyn’s picture

pazhyn commented
Issue tags: +CodeSprintUA
zviryatko’s picture

zviryatko commented
StatusFileSize
new smtp-display-configuration-overrides-2731283-6.patch7.16 KB
zviryatko’s picture

zviryatko commented
Status: Needs work » Needs review
zviryatko’s picture

zviryatko commented
StatusFileSize
new smtp-display-configuration-overrides-2731283-8.patch7.15 KB
dpovshed’s picture

dpovshed commented
Status: Needs review » Reviewed & tested by the community

Patch rom #8 looks great! Reviewed and tested manually, RTBC

wundo’s picture

wundo commented
wundo’s picture

wundo commented
Assigned: Unassigned » wundo
wundo’s picture

wundo commented
Category: Task » Bug report

  • wundo committed f8f17bd on 8.x-1.x authored by zviryatko 
    Issue #2731283 by zviryatko, pcambra, wundo, pazhyn, dpovshed: Display...
wundo’s picture

wundo commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.