Problem/Motivation

PHP 8.4 is now out, but this module is triggering a deprecation:

Deprecated: Drupal\jsonapi_extras\JsonapiResourceConfigListBuilder::__construct(): Implicitly marking parameter $entityTypeManager as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/modules/contrib/jsonapi_extras/src/JsonapiResourceConfigListBuilder.php on line 56
PHP Deprecated:  Drupal\jsonapi_resources\Resource\ResourceBase::createJsonapiResponse(): Implicitly marking parameter $links as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/modules/contrib/jsonapi_resources/src/Resource/ResourceBase.php on line 109

I'll go ahead and fix all the other outstanding phpcs issues.

CommentFileSizeAuthor
#8 3489101-MR-8.patch12.04 KBkiseleva.t

Issue fork jsonapi_extras-3489101

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ptmkenny created an issue. See original summary.

ptmkenny opened merge request !62

ptmkenny’s picture

ptmkenny commented
Assigned: ptmkenny » Unassigned
Status: Active » Needs review
bbrala’s picture

bbrala
Location Netherlands
commented

This seems relatively low risk seeing how long this has been supported.

bbrala’s picture

bbrala
Location Netherlands
commented
Status: Needs review » Fixed

  • bbrala committed 0ad3c77e on 8.x-3.x authored by ptmkenny 
    Issue #3489101 by ptmkenny, bbrala: PHP 8.4/phpcs: implicit nullable...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

kiseleva.t’s picture

kiseleva.t commented
StatusFileSize
new 3489101-MR-8.patch12.04 KB

Exported MR into patch to use in composer.

marcelovani’s picture

marcelovani
Primary language Portuguese, Brazil
Location London
commented

Can we have this on a new release?