Problem/Motivation

`aria-label="Opens in a new tab"` prevents the link text itself from being read by screen readers.

Steps to reproduce

Add an external link or content-link to a page. Ensure that "open external links in a new window" CivicTheme theme setting is enabled.

Proposed resolution

Remove the `aria-label="Opens in a new tab"` or replace it with `aria-label="{Link title}, Opens in a new tab"`

Remaining tasks

Change both link and content-link atom components.

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#12 Screenshot from 2025-07-14 16-33-46.png38 KBdivyansh.gupta
#12 Screenshot from 2025-07-14 16-34-24.png35.98 KBdivyansh.gupta

Issue fork civictheme-3488286

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nickgeorgiou created an issue. See original summary.

nickgeorgiou’s picture

nickgeorgiou commented
Title: External links should not » External links don't have the correct aria-label set
tirupati_singh’s picture

tirupati_singh commented
Assigned: Unassigned » tirupati_singh

I'm working on it.

tirupati_singh opened merge request !14

tirupati_singh’s picture

tirupati_singh commented
Assigned: tirupati_singh » Unassigned
Status: Active » Needs review

Hi, I've fixed the external link aria-label issue. Please review the changes.
Thanks!

joshua1234511’s picture

joshua1234511
Primary language English
Location Goa
commented

Thank you for submitting the Merge Request!

Issue has been raised under similar concept: https://github.com/civictheme/uikit/issues/436

For any support or Merge Requests related to the Drupal theme, you can raise them on the

For the Drupal theme: https://github.com/civictheme/monorepo-drupal
For UI Kit updates: https://github.com/civictheme/uikit

fionamorrison23’s picture

fionamorrison23 commented
Version: 1.8.2 » 1.x-dev
fionamorrison23’s picture

fionamorrison23 commented
Issue tags: +civictheme-release-1.11

fionamorrison23 credited richardgaunt.

fionamorrison23’s picture

fionamorrison23 commented
fionamorrison23’s picture

fionamorrison23 commented
Assigned: Unassigned » richardgaunt
Issue tags: -civictheme-release-1.11 +civictheme-release-1.12
divyansh.gupta’s picture

divyansh.gupta commented
Status: Needs review » Needs work
StatusFileSize
new Screenshot from 2025-07-14 16-34-24.png35.98 KB
new Screenshot from 2025-07-14 16-33-46.png38 KB

I was able to reproduce this issue and this MR solved the issue for me.
Before:
before
After:
after
Ready for RTBC, but there are some merge conflicts, thus moving it back to Needs Work!!

fionamorrison23’s picture

fionamorrison23 commented
Status: Needs work » Needs review
fionamorrison23’s picture

fionamorrison23 commented
fionamorrison23’s picture

fionamorrison23 commented
Version: 1.x-dev » 1.11.0
Status: Needs review » Reviewed & tested by the community
Issue tags: -civictheme-release-1.12 +civictheme-release-1.11

This was actually released in CivicTheme 1.11. Thanks @tirupati_singh and @divyansh.gupta for your work.

fionamorrison23’s picture

fionamorrison23 commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.