Problem/Motivation

Automated scans with phpstan in GitLabCI raise errors.
Current phpstan pipeline: https://git.drupalcode.org/issue/webform-3474074/-/jobs/2920066

Proposed resolution

Fix the phpstan pipeline.

Issue fork webform-3477942

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

liam morland created an issue. See original summary.

ankitv18’s picture

ankitv18 commented
Issue summary: View changes

ankitv18 opened merge request !521

acbramley’s picture

acbramley commented
Status: Active » Postponed

I would recommend holding off on all of these pipeline fixes until the D11 branch is merged. Otherwise we're going to have major conflicts which will be very hard to manage.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Many of these are needed for D11 compatibility. The D11 issue is being split into focussed issues. This issue could be part of that process.

acbramley’s picture

acbramley commented

@liam morland legitmate issues, sure, but making phpstan green in CI is not required for D11. The branch also needs a rebase with HEAD.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Postponed » Needs work
Issue tags: +Needs reroll

D11 branch is merged.

idebr made their first commit to this issue’s fork.

idebr’s picture

idebr commented
Issue tags: -Needs reroll

The phpstan pipeline is now fixed, but one test is now failing. Oddly enough it doesn't fail on my local machine.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Issue tags: +Needs reroll

Tests are passing again on 6.3.x. Please reroll and get tests to pass.

kul.pratap’s picture

kul.pratap commented
Assigned: Unassigned » kul.pratap
kul.pratap’s picture

kul.pratap commented
Assigned: kul.pratap » Unassigned
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Tests are passing again on 6.3.x. Please reroll and get tests to pass.

jrockowitz made their first commit to this issue’s fork.

jrockowitz’s picture

jrockowitz commented

BTW, it fine to ignore a few tricky phpstan errors via // @phpstan-ignore-next-line property.notFound.

@see https://phpstan.org/user-guide/ignoring-errors

jrockowitz’s picture

jrockowitz commented

BTW, it fine to ignore a few tricky phpstan errors via // @phpstan-ignore-next-line property.notFound.

@see https://phpstan.org/user-guide/ignoring-errors

kul.pratap’s picture

kul.pratap commented
Assigned: Unassigned » kul.pratap
kul.pratap’s picture

kul.pratap commented
Assigned: kul.pratap » Unassigned
Status: Needs work » Needs review

There is no phpstan error. Please review.

idebr’s picture

idebr commented
Status: Needs review » Needs work

See #9

jrockowitz’s picture

jrockowitz commented

The failing test is only happening in D11.1

idebr’s picture

idebr commented
Status: Needs work » Needs review
Issue tags: -Needs reroll

Fixed the last test failure.

  • jrockowitz committed da4cb882 on 6.3.x authored by ankitv18 
    Issue #3477942 by idebr, ankitv18, kul.pratap, jrockowitz, liam morland...
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed

I am going to go with this MR is good enough. The only breaking change is the removal of the completely unused \Drupal\webform\Plugin\WebformElement\TextFormat::hasCompositeElement added in 2017.

  • jrockowitz committed da4cb882 on 6.x authored by ankitv18 
    Issue #3477942 by idebr, ankitv18, kul.pratap, jrockowitz, liam morland...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.