Problem/Motivation

Follow-up to #3465838: Drupal 11 compatibility fixes for webform. There are a number of linting warnings including:

  • cspell

Proposed resolution

In this ticket, fix the cspell errors.

Remaining tasks

Implement.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork webform-3474074

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kim.pepper created an issue. See original summary.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Issue summary: View changes

phpcs is currently passing, but others are not. It might be a good idea to have separate issues for each linter.

ankitv18 made their first commit to this issue’s fork.

ankitv18’s picture

ankitv18 commented
Version: 6.x-dev » 6.3.x-dev

ankitv18 opened merge request !520

jrockowitz’s picture

jrockowitz commented

Please lets fix one linting issue per ticket.

Let's address cspell in this ticket.

I think phpstan and phpcbf issue will be much harder to safely address.

  • liam morland committed debf0270 on 6.3.x 
    Issue #3474074: Mark nullable parameters with null defaults

  • liam morland committed debf0270 on 6.x 
    Issue #3474074: Mark nullable parameters with null defaults
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

phpcs had been passing and should be passing again with the above changes.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Title: Fix gitlabci linting errors » Fix cspell errors
Issue summary: View changes
ankitv18’s picture

ankitv18 commented

Yes I'm working on cspell pipeline fix only on this issue ~~ will create separate issues for rest of the pipeline fixes.

cc: @liam morland @jrockowitz

ankitv18’s picture

ankitv18 commented
Status: Active » Needs review

MR!520 is ready for a review

ankitv18’s picture

ankitv18 commented
Issue summary: View changes
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Thanks for the patch.

Why is this needed?

<exclude name="DrupalPractice.Commenting.CommentEmptyLine.SpacingAfter"/>

ankitv18’s picture

ankitv18 commented

Even with the proper commenting to include cspell:ignore, the phpcs throws warnings
Please see: https://git.drupalcode.org/issue/webform-3474074/-/jobs/2919966#L43

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Can you not use phpcs:ignore to fix that? Or not have the blank line after?

I suspect that "durpalicon" should be "drupalicon".

ankitv18’s picture

ankitv18 commented

All done and dusted ~~ Cspell and phpcs both pipelines are clean now.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

"Uable" should probably be "Unable".

ankitv18’s picture

ankitv18 commented

@liam morland Please review the MR

jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

liam morland opened merge request !640