Closed (fixed)
Project:
CivicTheme Design System
Version:
1.10.0
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
20 Sep 2024 at 05:44 UTC
Updated:
21 Apr 2025 at 00:39 UTC
Jump to comment: Most recent
Comments
Comment #2
simeMarked https://www.drupal.org/project/civictheme/issues/3475985 as a duplicate.
Comment #3
richardgaunt commented@sime
This is our proposed fix.
Update civictheme_media_get_variables to handle the OEmbed (remote video).
We want to only return the properties that are useful for remote video:
Do not return other properties.
Does this align with your thinking?
Comment #4
sourav_paulComment #5
sourav_paulComment #6
joshua1234511OEmbed (remote video) is already handled similarly to other media components, with:
civictheme_preprocess_media__civictheme_remote_videofor Remote Videocivictheme_preprocess_media__civictheme_videofor Video.Is there a specific reason to use civictheme_media_get_variables() for this case?
In the current setup, this function is used only for attachments (Documents), and an image which always include an associated file.
Comment #7
richardgaunt commentedYes the purpose is for this to be a utility to get values for a variety of different field types. As you say it only handles file type of media it would be good if it could be used for video
Comment #8
fionamorrison23 commentedComment #9
richardgaunt commentedComment #10
richardgaunt commentedComment #11
richardgaunt commentedComment #13
fionamorrison23 commentedComment #14
fionamorrison23 commentedComment #15
richardgaunt commentedComment #16
fionamorrison23 commentedComment #17
fionamorrison23 commentedComment #18
fionamorrison23 commentedComment #19
fionamorrison23 commented