Drupal 11 preparedness

Working on a plan to fork bootstrap 3.4.x and provide a jQuery 4 compatible version.

https://github.com/wet-boew/wet-boew/issues/9808

I've got bootstrap 3 functioning on Drupal 11.0.3

Instructions and illustrations here:

#3428283-38: Automated Drupal 11 compatibility fixes for bootstrap 8.x-3.x

Next step is to make it work with wet-boew.

This might eventually require forking wet-boew just as I have forked bootstrap.

 ╰❯ $ drush upgrade_status:analyze wxt_library
 [notice] Processing /var/www/d11/web/modules/contrib/wxt_library.

================================================================================
WxT Library,  8.x-8.3
Scanned on mer 13/11/2024 - 17:48

FILE: web/modules/contrib/wxt_library/wxt_library.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 4    Value of core_version_requirement: ^9 || ^10 is not         
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE: web/modules/contrib/wxt_library/composer.json

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 1    The drupal/core requirement is not compatible with the next 
                    major version of Drupal. Either remove it or update it to be
                    compatible. See                                             
                    https://www.drupal.org/docs/develop/using-composer/add-a-com
                    poserjson-file#core-compatibility.                          
--------------------------------------------------------------------------------

now for wxt_bootstrap:

 ╰❯ $ vendor/drush/drush/drush upgrade_status:analyze wxt_bootstrap
 [notice] Processing /var/www/d11/web/themes/contrib/wxt_bootstrap.

================================================================================
WxT Bootstrap, --
Scanned on mer 13/11/2024 - 17:51

FILE: web//var/www/d11/vendor/symfony/deprecation-contracts/function.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 25   Since twig/twig 3.9: Using the internal                     
                    "twig_escape_filter_is_safe" function is deprecated.        
--------------------------------------------------------------------------------

FILE:
web/themes/contrib/wxt_bootstrap/templates/block/block--block-content--search.ht
ml.twig

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 72   Twig template                                               
                    themes/contrib/wxt_bootstrap/templates/block/block--block-co
                    ntent--search.html.twig contains a syntax error and cannot  
                    be parsed.                                                  
--------------------------------------------------------------------------------

FILE: web/themes/contrib/wxt_bootstrap/templates/file/file-link.html.twig

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Ignore         18   Since twig/twig 3.12: Twig Filter "spaceless" is deprecated.
                    See https://drupal.org/node/3071078.                        
--------------------------------------------------------------------------------

FILE:
web/themes/contrib/wxt_bootstrap/templates/input/input--button--split.html.twig

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Ignore         26   Since twig/twig 3.12: Twig Filter "spaceless" is deprecated.
                    See https://drupal.org/node/3071078.                        
--------------------------------------------------------------------------------

FILE:
web/themes/contrib/wxt_bootstrap/templates/input/input--button--submit.html.twig

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Ignore         25   Since twig/twig 3.12: Twig Filter "spaceless" is deprecated.
                    See https://drupal.org/node/3071078.                        
--------------------------------------------------------------------------------

FILE: web/themes/contrib/wxt_bootstrap/templates/input/input--button.html.twig

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Ignore         25   Since twig/twig 3.12: Twig Filter "spaceless" is deprecated.
                    See https://drupal.org/node/3071078.                        
--------------------------------------------------------------------------------

FILE:
web/themes/contrib/wxt_bootstrap/templates/input/input--form-control.html.twig

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Ignore         24   Since twig/twig 3.12: Twig Filter "spaceless" is deprecated.
                    See https://drupal.org/node/3071078.                        
--------------------------------------------------------------------------------

FILE: web/themes/contrib/wxt_bootstrap/templates/input/input.html.twig

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Ignore         22   Since twig/twig 3.12: Twig Filter "spaceless" is deprecated.
                    See https://drupal.org/node/3071078.                        
--------------------------------------------------------------------------------

FILE: web/themes/contrib/wxt_bootstrap/templates/input/select.html.twig

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Ignore         18   Since twig/twig 3.12: Twig Filter "spaceless" is deprecated.
                    See https://drupal.org/node/3071078.                        
--------------------------------------------------------------------------------

FILE: web/themes/contrib/wxt_bootstrap/templates/system/page.html.twig

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 138  Twig template                                               
                    themes/contrib/wxt_bootstrap/templates/system/page.html.twig
                    contains a syntax error and cannot be parsed.               
--------------------------------------------------------------------------------

FILE: web/themes/contrib/wxt_bootstrap/wxt_bootstrap.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 4    Value of core_version_requirement: ^9 || ^10 is not         
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE: web/themes/contrib/wxt_bootstrap/composer.json

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 1    The drupal/core requirement is not compatible with the next 
                    major version of Drupal. Either remove it or update it to be
                    compatible. See                                             
                    https://www.drupal.org/docs/develop/using-composer/add-a-com
                    poserjson-file#core-compatibility.                          
--------------------------------------------------------------------------------

First the good news!

I was able to frankenstein a build of Drupal 11 that included the wet-boew libraries
and patched wxt_bootstrap / wxt_library for Drupal 11 compatibility, what is fairly impressive is that things are mostly working in this state.

I have some very lightly tested patches for wxt_library / wxt_bootstrap , there are likely regressions that I haven't caught yet.

The somewhat expected challenge remaining is the fact that wet-boew includes Modernizr (only required for IE which is no longer support) minor jQuery v4 compatibility challenges to work out. With that said, it's all looking fairly good with the upgraded bootstrap library.

The version of bootstrap being used is straight off the D11 merge request commit following the instructions mentioned here:
#3428283: Automated Drupal 11 compatibility fixes for bootstrap 8.x-3.x

Screenshot of this progress:

I've forked wet-boew and working on jQuery 4 compatibility fixes, I'll be testing local builds before pushing it up for review to the wet-boew folks.

No longer need to use the merge request branch from https://drupal.org/project/bootstrap , there is now a D11 compatible version in the 8.x-3.x branch (not yet tagged, I'm verifying a few things yet before making a tag).

https://www.drupal.org/project/bootstrap/releases/8.x-3.x-dev

More good news, I pushed a PR up to wet-boew that resolves the jQuery 4 compatibility issues in wet-boew.js.

The PR only resolves the jQuery 4 compatibility issues noticed when using Drupal 11 / wxt_library /wxt_bootstrap as described above, but also has passed the wet-boew lint and automated testing.

Screenshots in the PR of before/after.

https://github.com/wet-boew/wet-boew/pull/9831

Once they approve/merge the PR we'll likely want to crank up our wet-boew from 4.0.75 to 4.0.83 . I'm hoping this jQuery 4 fix makes it into 4.0.83.

@smulvih2, we're basically at the point now where we need a wxt 6 branch and we need to think about pushing up/reviewing the wxt_library and wxt_bootstrap related changes, review and test those and then get started on the wxt custom module upgrades from 10 to 11.

Meanwhile, I'll continue working towards a tagged release of the https://drupal.org/project/bootstrap build which is fairly close as it's in 8.x-3.x dev right now.

The wet-boew PR for jQuery 4 compatibility has been pre-approved by Garneauma and is undergoing thorough testing which I suspect will pass.

• wxt_library patch for Drupal 11 compatibility
• wxt_bootstrap patch for Drupal 11 compatibility

It would be good to get some mileage (additional testing) on the wxt_bootstrap patch against Drupal 10 and wxt 5.3.x in preparation for D11.

w00t!

WET-BOEW merged our pull request.

The next release of WET-BOEW will be compatible with jQuery 4 and thus compatible with Drupal 11!

https://github.com/wet-boew/wet-boew/commits/master/

Meanwhile over 1200 new installs of bootstrap 3.33 which includes the Drupal 11 in only 5 days of statistics being collected. Zero complaints from any of those.

@smulvih2
*** unrelated to WxT but is related to Drupal 11 upgrade ***
FYI, there's a new module that replaces embed_block

https://www.drupal.org/project/ckeditor_insert_blocks

I believe you had done some work on this.

The embed_block maintainer has not taken much action for a few years now and ckeditor_insert_blocks is designed for use with ckeditor5
*** End of unrelated to WxT ***

For the D11 upgrade, it will have to target 11.1 as this is the expected upgrade path from 10.4

Today in the #d11readiness slack channel , been discussing the fontawesome D11 upgrade with one of their maintainers. Expect it to be ready this week, possibly tonight.

Let's take inventory of all the modules for wxt , hopefully everything else is ready. Some maintainers are forced a contrib major version change but often it's really minor.

wet-boew v4.0.83 was tagged and released and is compatible with jQuery 4 which means it is now compatible with Drupal 11.

bootstrap 3.34 (over 5000 installs after only a few weeks)
with
wet-boew v4.0.83

are compatible with Drupal 10.4.0 and also Drupal 11.1.0+

Meanwhile, views_bootstrap has a dev release available which is compatible with Drupal 11. I will ping the maintainer to ask for a tagged release. With that said, we can start with this: https://www.drupal.org/project/views_bootstrap/releases/5.3.x-dev

@smulvih2, ah, no, bootstrap 5 is not compatible with bootstrap 3, use drupal/bootstrap: ^3.34

The maintainer from Bario managed to take over the 5.x branch which has nothing to do with the version we need.

This is the release we need:

https://www.drupal.org/project/bootstrap/releases/8.x-3.34

as for views_bootstrap

use the dev release, it is Drupal 11 compatible:

composer require 'drupal/views_bootstrap:5.3.x-dev@dev'

@smulvih2 , reminder if you have not done so already. For Drupal 11 compatibility please make sure to apply the patch to wxt_library

https://www.drupal.org/files/issues/2024-11-13/wxt_library-3466676-14.patch

and the patch to wxt_bootstrap

https://www.drupal.org/files/issues/2024-11-13/wxt_bootstrap-3466676-14....

Hmm, ok, time to make another PR to fix that. Ah, it's a dependency

js/deps (deps=dependency)

still will need a PR.

Logged an issue upstream in wet-boew/wet-boew

Hope to fix soon

https://github.com/wet-boew/wet-boew/issues/9846

possible workaround suggestion:

Should be an easy fix/workaround for this:
Add this Javascript, ensure it loads just before or after (maybe try both) wet-boew.js

if (typeof Zepto !== 'undefined' && typeof Zepto.isArray !== 'function') {
    Zepto.isArray = Array.isArray;
}

If that doesn't work, do the same thing for jQuery

if (typeof jQuery !== 'undefined' && typeof jQuery.isArray !== 'function') {
    jQuery.isArray = Array.isArray;
}

Testing it out, needs a couple patches:

Another patch

patch 42a fixes allowing turning on and off css / js aggregation and cache settings.
patch 42b allows changing the wxt_library theme
patch 43 resolves a php warning/error message that is thrown by the report a problem form

drupaloverride/entity_browser_block

can be replaced with

drupal/entity_browser_block:'^2.0'

@smustgrave became maintainer of entity_browser_block and he published a D11 release for this one tuesday jan 14.

Share this page works wonderfully, had to try it! :)

Replace one of those patches.

and this patch for page_manager has to go on top of our other page_manager patches, put it at the end.

To reproduce the bug, log out of wxt vanilla and log back in again. You'll see a page_manager exception which prevents log-in. This patch fixes it. With that said, something is broken with H1 titles, I've got sample content loaded but I don't see the title. Probably related.

Cool, great work. I'll update my build soon and check this out. The Ajax fix sounds perfect thanks

Hiding the related patches here accordingly.

ok wow, kinda weird but ya great sleuthing!

Ok, a bit of a minor issue for me, as I can do workarounds, but we could smoothen this part out.

In order to upgrade to WxT 6.1.x the following modules must be uninstalled before going into D11

• ckeditor this module is not available in D11 and will not be made available
• ckeditor4_codemirror (while this module IS Drupal 11 compatible, it has a dependency on the "ckeditor" module which is marked obsolete/unsupported thus preventing it from being installed in D11).

Here's what happens when you try to uninstall keditor4_codemirror in WxT 5.4.x:

do you also want to uninstall wxt_ext_editor? So there's a dependency set in wxt_ext_editor, which is fine for 5.4.x but in 6.1.x there's no ckeditor4_codemirror module available. It could be faked out with a stub module like drush gen module. just to get an info.yml for it to be able to uninstall it. I'll do this myself but we could make this easy by including this in the wxt/custom/modules

core modules removed from D11

• tour
• action

These two modules can be brought back in via contrib, I'll do this

composer require drupal/tour:'^2.0'
composer require drupal/action:'^0.2'

ok not such a big deal for the core modules, they're now available in contrib.

action is required for things like vbo and I know moderated_content_bulk_publish likely needs it.

codemirror - test to see how this is working.

This is the library I'm including:

        {
            "type": "package",
            "package": {
                "name": "cdubz/ckeditor5-source-editing-codemirror",
                "version": "35.1.0",
                "type": "drupal-library",
                "extra": {
                    "installer-name": "ckeditor5-source-editing-codemirror"
                },
                "dist": {
                    "url": "https://registry.npmjs.org/@cdubz/ckeditor5-source-editing-codemirror/-/ckeditor5-source-editing-codemirror-35.1.0.tgz",
                    "type": "tar"
                },
                "require": {
                    "composer/installers": "*"
                }
            }
        },
        {
            "type": "package",
            "package": {
                "name": "codemirror/codemirror",
                "version": "5.65.12",
                "type": "drupal-library",
                "extra": {
                    "installer-name": "codemirror"
                },
                "dist": {
                    "url": "https://registry.npmjs.org/codemirror/-/codemirror-5.65.12.tgz",
                    "type": "tar"
                },
                "require": {
                    "composer/installers": "*"
                }
            }
        },

and then corresponding entries in the require section of the composer.json

from the ckeditor_codemirror composer.libraries.json:

@smulvih2,

reminder, since we're using overrides, the namespace of patches needs to follow suit.

What I'm doing is this:

            "drupaloverride/layout_builder_st": {
                "3069964 - Argument 1 passed to isTranslation must implement SectionStorageInterface, null given.": "https://www.drupal.org/files/issues/2025-01-02/3069964-null-fix.patch"                 
            },      
            "drupal/layout_builder_st": {
                "3069964 - Argument 1 passed to isTranslation must implement SectionStorageInterface, null given.": "https://www.drupal.org/files/issues/2025-01-02/3069964-null-fix.patch"
            },

I'm keeping both, since eventually we'll remove the overrides but we need the patches either way (for now).

This applies to other drupaloverrides modules, we're possibly missing patches for when running 6.1.x.

Definately need this null-fix patch. I hit this when trying to log in.

Found (and fixed) a deprecation issue caused by using a deprecated createPseudo call in wet-boew.js

tested a fix, success

openned a PR for wet-boew

Issue link:
https://github.com/wet-boew/wet-boew/issues/9851

@smulvih2 , bootstrap 3.34 requires version 3.4.4 of the library

you can select this in the cdn provider option by toggling and switching to jsdelivr

yes bootstrap 3.34 has these fixes and we cannot use twbs/bootstrap 3.4.1 it has to be entreprise7pro/bootstrap 3.4.4 to attain jQuery v4 support. We'll have to sort this out.

Here's the jQuery 4 fixes for the outdated js in wxt_bootstrap

This brings us up to 3.4.4

I updated the release notes for bootstrap 3.35 , and updated a related support request relating to this.

The correct configuration for subtheme cdn settings is to leave it to "compiled" and "none". The bootstrap theme settings should be the only decider here due to the need to do an automatic upgrade as Drupal 11 does not support twitter bootstrap, it only supports entreprise7pro bootstrap.

Instructions are in the release notes https://www.drupal.org/project/bootstrap/releases/8.x-3.35

The Default install of WxT 6.1.x does not have an issue.

Extensive testing - Discovered something that looks like a wxt bug, might be also in 5.4 but I'm seeing this in 6.1.x

Step 1) edit or add a user then select a picture for them

illustration:

Step 2) Check the browser console ajax exception message

Untested patch, possibly helps with comment #74

Patch #75 leads to something deeper with the file extension validation going on in wxt_ext_media. Here's the related change notice:

https://www.drupal.org/node/3363700

The new approach was introduced in version: 10.2.0, however the deprecated approach was removed in 11.0.0.

So , therefore, bunch of refactoring is needed in wxt_ext_media. See the change notice for more details on how to refactor related wxt_ext_media validation logic. A bit tricky business.

New patch, testing it.

patch 77 is an incomplete refactor, working on it. next one I will test before uploading.

ok new patch, it's not working yet, not sure what the issue is caused by whether it's dropzonejs or an incorrect refactor of wxt_ext_media

This patch was created as an attempt to follow this change notice : https://www.drupal.org/node/3363700

It's a work in progress.

Ok another patch, still doesn't fix the issue but gets us closer.

This patch was created as an attempt to follow this change notice : https://www.drupal.org/node/3363700

It's a work in progress.

new patch.
it's better but still not complete.

Ok I've dug deeper into this, my patch is really close.

With that said, I found out that degov , govcms and vardot also used lightning_media

They're now using media_bulk_upload.

There's a MASSIVE merge request for media_bulk_upload to make it Drupal 11 compatible and it is marked RTBC with a lot of work having gone into it.

https://www.drupal.org/project/media_bulk_upload/issues/3431856

At some point (soon?), we should look at replacing wxt_ext_media_bulk_upload with
media_bulk_upload.

With that said, still need to fix wxt_ext_media, not bulk.

Ok here's another patch, this one actually behaves much better than 5.4.x which is completely broken btw.

This patch can be applied to both 5.4.x and 6.1.x

One more patch, this time for wxt_bootstrap. I'll also have to put this into the entreprise7pro/bootstrap build.

is meant for 6.1.x mostly

• Patch wxt ( pull request for upload with Entity Browser (see screenshots above) )
• Patch wxt_bootstrap for improved jQuery 4 compatibility ( pull request )
• todo for a future release (doesn't have to be 6.1.0) replace wxt_ext_media_bulk_upload with media_bulk_upload

In addition to the pull requests, there's a bunch of the overrides modules that got releases. Go through those soon.

The js patch is related to an upstream js change in bootstrap 3.4.6
https://github.com/entreprise7pro/bootstrap/compare/v3.4.5...v3.4.6#diff...

To help soften the landing of Drupal 11 we've created a new contrib module:

JQuery Downgrade

• jQuery downgrade, aiming to keep the use of this module to the bare minimum as from what we can tell so far the WxT distribution out of the box doesn't need any special treatment like this.
• Created because we live in an imperfect world and have to be pragmatic.
• The jquery_downgrade module gives us flexibility to "downgrade" for a specific node (nid) or set of nodes (one per line) or view pages and can optionally be downgraded globally on a per theme bases.
• Additional configuration options are foreseen and patches to improve this module will be recieved warmly.

Relating to the fontawesome library , the namespace in packagist is actually forkawesome/font-awesome

https://packagist.org/packages/fortawesome/font-awesome

6.2 million installs

74,000+ stars

There's still two overrides plus the fontawesome/fontawesome bit that you'll need in your projects for upgrades. I also just openned a merge request for wxt_library to upgrade wet-boew from 4.0.83 to 4.0.85 (fixes a jQuery 4 compatibility issue we found).

Ok great, we could also look at upgrading gcweb to 16.2.0 from 14.6.0 at some point but less urgent.

composer create-project drupalwxt/site-wxt:11.1.x-dev <site-name> --no-interaction

I got the answer from a documentation thread you are following.

There's a PR ready and waiting but it has to be merged.

from this issue:
#3506584-5: Add missing documentation in the official page

ya that's Drupal 12 stuff, we have time to work on that, with that said, we can start working on those items.

We're focused right now mostly on immediate concerns relating to Drupal 11.

Thanks @web247

I've created an issue for that

#3508590: Countries test failure in a vanilla install

Linking the plan for WxT 6.1.0