Drupal 11 compatibility for Video Embed Field

For CKEditor support, including drop functionality and CKEditor 5 support, please see updates at #3311063: Add support for Ckeditor 5 (get Video Embed Wysiwyg back).
For drush_print deprecation, please see updates at #3123204: Fixing namespace for oEmbedUpdateTest, remove deprecated Drush command.
For access to undefined property render, please see updates at #3443389: Property 'render' declared dynamically.

Please review.

Please review.

For next major we are waiting on #3311063: Add support for Ckeditor 5 (get Video Embed Wysiwyg back).

PR !36 changes looks good to me, though D11 ci is failing hence its can't be consider for review. Hence needs work.

CKEditor5 related changes are now completed as part of #3311063: Add support for Ckeditor 5 (get Video Embed Wysiwyg back).
D11, CKE5 and other blocker issue changes combined here and CI result see here.

D11 CKE5 issue with Undefined array key "status" in editor_form_filter_admin_format_submit() is #3457717: Undefined array key "status" in editor_form_filter_admin_format_submit() (line 257 of core/modules/editor/editor.module)..

Requesting review.

@vishal.khode, updated MR with feedback changes.

Reviewed changes, looks good to me now. Hence, RTBC.

Hi,

I am trying to install the MR 36 as a patch (https://git.drupalcode.org/project/video_embed_field/-/merge_requests/36...)

composer require 'drupal/video_embed_field:^2.5'

the composer.json also has the following

in the require definitions:
"cweagans/composer-patches": "^1.7"

and in the patches section:

"drupal/video_embed_field":{
				"https://www.drupal.org/project/video_embed_field/issues/3465381 Drupal 11 compatibility for Video Embed Field" :"https://git.drupalcode.org/project/video_embed_field/-/merge_requests/36.patch"
            },

$ composer require 'drupal/video_embed_field:^2.5' -v

But the patch fails to apply - I have edited the output down to make it a little easier to read through, it is essentailly a list of all the patched files "can't find file to patch at input line..":

Found 1 patches for drupal/video_embed_field.

> post-package-install: cweagans\Composer\Patches_composer_tmp1->postInstall
  - Applying patches for drupal/video_embed_field
    https://git.drupalcode.org/project/video_embed_field/-/merge_requests/36.patch (https://www.drupal.org/project/video_embed_field/issues/3465381 Drupal 11 compatibility for Video Embed Field)
patch "-p1" --no-backup-if-mismatch -d "web/modules/contrib/video_embed_field" < "C:\Users\ice70\AppData\Local\Temp/66fd2fd4c4f7d.patch"
patching file modules/video_embed_media/modules/vem_migrate_oembed/vem_migrate_oembed.info.yml
...
can't find file to patch at input line 767
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/modules/video_embed_media/modules/vem_migrate_oembed/tests/src/Functional/OEmbedUpdateTest.php b/modules/video_embed_media/modules/vem_migrate_oembed/tests/src/Functional/OEmbedUpdateTest.php
|index 1aad766..e90a8c2 100644
|--- a/modules/video_embed_media/modules/vem_migrate_oembed/tests/src/Functional/OEmbedUpdateTest.php
|+++ b/modules/video_embed_media/modules/vem_migrate_oembed/tests/src/Functional/OEmbedUpdateTest.php
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
2 out of 2 hunks ignored

How do I get the MR 36 patch to apply?

@ice70 try to patch with the .diff file instead

https://git.drupalcode.org/project/video_embed_field/-/merge_requests/36...

Hi @rajeshreeputra thanks for all your great work on this Drupal 11 compatibility issue.

I have initialized a 3.0.x branch with hopefully most of the fixes required for Drupal 11 and all tests are green in Gitlab CI.

I had to remove the wysiwyg submodule for now as CKEditor 4 is incompatible with Drupal 11.

Feel free to check the 3.0.x code and see if things are wrong or missing.

Hi @mably, sure will take a look. Thank you for updates!

1. I did another static analysis of the 3.0.x branch and it did not report any PHP or Drupal deprecations.
2. I installed the 3.0.x branch with the latest version of Drupal 11, both the main module and the media submodule, and confirmed that I was able to add and render a field to a node successfully, and add a new media item with the video_embed_field media plugin.

A 3.x release would be wonderful, if even marked as an alpha release.

Given that the CKEditor (4) integration has been removed in this branch, I think the module project page should also be updated to indicate that the 3.x branch does not provide *any* WYSIWYG integration (as I don't see any CKEditor 5 implementation).

Hi @mark_fullmer, the 3.0.0-alpha1 version has been released.

Module page updated for CKEditor integration warning.

Thanks so much!