Problem/Motivation

We're currently on 42.0.0, 42.0.2 contains several bugfixes.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#13 3464020-nr-bot.txt90 bytesneeds-review-queue-bot

Issue fork drupal-3464020

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: Unassigned » spokje

Spokje opened merge request !8943

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review

Well, that was easier than expected...

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

We should get this in ASAP and ship it with 11.0.0.

  • nod_ committed e1ba327c on 11.0.x 
    Issue #3464020 by Spokje, catch, longwave: Update to ckeditor 42.0.2

(...

  • nod_ committed ae638ca0 on 11.x 
    Issue #3464020 by Spokje, catch, longwave: Update to ckeditor 42.0.2

nod_ closed merge request !8943

nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 11.x-dev » 10.4.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed ae638ca and pushed to 11.x. Thanks!
Committed e1ba327 and pushed to 11.0.x. Thanks!

10.4.x is also on 42.0.0, will need a MR for it

Spokje opened merge request !8946

spokje’s picture

spokje
Primary language Dutch
commented
Status: Patch (to be ported) » Needs review

Besides a warning in the config validation which I don't understand:

$ git checkout -f $CI_MERGE_REQUEST_DIFF_BASE_SHA
fatal: reference is not a tree: 93b747d5e3f13dc80426d9891f34c94afe179278

all seems well.

Ah, I forgot about the "convenient" functionality of GitLab that wants to merge any MR, even if _explicitily_ created from another branch, merged into the default(?) one 11.x.
So you have to _manually_ tell it you _really_ meant it when you mentioned that other branch.

TLDR: Told Gitlab to use 10.4.x and all seems well.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3464020-nr-bot.txt90 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Needs review
Issue tags: +no-needs-review-bot

Nope, not improving my mood.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Fixed

Thanks, all good.

Committed 196137e and pushed to 10.4.x. Thanks!

  • nod_ committed 196137ea on 10.4.x 
    Issue #3464020 by Spokje, catch, longwave, nod_: Update to ckeditor 42.0...

nod_ closed merge request !8946

spokje’s picture

spokje
Primary language Dutch
commented
Issue tags: +11.0.0 release notes, +10.4.0 release notes

Probably should be in the release notes.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Parent issue: » #3459926: Update CKEditor 5 to 42.0.0