Problem/Motivation

https://github.com/ckeditor/ckeditor5/releases/tag/v42.0.0

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3459926

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

longwave created an issue. See original summary.

longwave’s picture

Status: Active » Needs review
longwave’s picture

Status: Needs review » Needs work

ImageUrlTest has broken, probably due to this minor breaking change from the release notes:

The Insert image via URL UI component form has been moved to a modal dialog instead of being available directly in the insert image dropdown.

spokje’s picture

longwave’s picture

Status: Needs work » Needs review

Fixed the test to look for the CSS selectors in the dialog instead of the panel.

spokje’s picture

Status: Needs review » Reviewed & tested by the community

Code changes make sense and tests are green => RTBC

  • catch committed f0dee9ba on 11.x
    Issue #3459926 by longwave: Update CKEditor 5 to 42.0.0
    

  • catch committed cb69f88f on 11.0.x
    Issue #3459926 by longwave: Update CKEditor 5 to 42.0.0
    
    (cherry picked...
catch’s picture

Version: 11.x-dev » 10.4.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed/pushed to 11.x and cherry-picked to 11.0.x, thanks!

We should backport this to 10.4.x but that will require a separate MR since it's not a clean cherry-pick.

spokje’s picture

Assigned: Unassigned » spokje

Lemme have a go at this, as I presume that @longwave is busy enough with more important RC1 stuff (like all other core committers ofc)

spokje’s picture

Status: Patch (to be ported) » Needs review
spokje’s picture

Assigned: spokje » Unassigned

  • catch committed 15e33ca1 on 10.4.x
    Issue #3459926 by longwave, Spokje, catch: Update CKEditor 5 to 42.0.0
    
catch’s picture

Status: Needs review » Fixed
Issue tags: +10.4.0 release notes, +11.0.0 release notes

Same actual code changes as the 11.x MR so going to go ahead here.

Committed/pushed to 10.4.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

wim leers’s picture