Closed (fixed)
Project:
Drupal core
Version:
10.4.x-dev
Component:
ckeditor5.module
Priority:
Critical
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
26 Jul 2024 at 13:08 UTC
Updated:
18 Sep 2024 at 09:18 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
spokjeComment #4
spokjeWell, that was easier than expected...
Comment #5
spokjeComment #6
longwaveWe should get this in ASAP and ship it with 11.0.0.
Comment #10
nod_Committed ae638ca and pushed to 11.x. Thanks!
Committed e1ba327 and pushed to 11.0.x. Thanks!
10.4.x is also on 42.0.0, will need a MR for it
Comment #12
spokjeBesides a warning in the config validation which I don't understand:all seems well.
Ah, I forgot about the "convenient" functionality of GitLab that wants to merge any MR, even if _explicitily_ created from another branch, merged into the default(?) one
11.x.So you have to _manually_ tell it you _really_ meant it when you mentioned that other branch.
TLDR: Told Gitlab to use
10.4.xand all seems well.Comment #13
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #14
spokjeNope, not improving my mood.
Comment #15
nod_Thanks, all good.
Committed 196137e and pushed to 10.4.x. Thanks!
Comment #18
spokjeProbably should be in the release notes.
Comment #20
wim leers