[1.0.x] Domain Access Webform

Thank you for applying!

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications, Application workflow, What to cover in an application review, and Tools to use for reviews.

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues.

Remember to change status, when the project is ready to be reviewed. In this queue, projects are only reviewed when the status is Needs review.

1. FILE: domain_access_webform.module

/**
 * @file
 * Primary module hooks for domain_access_webform module.
 */

Drupal does not have primary and secondary hooks. Instead of that, it is preferable to use the usual description: Hook implementations for the [module name] module. where [module name] is the name of the module given in its .info.yml file.

/**
 * Implements hook_query_TAG_alter().
 */
function domain_access_webform_query_domain_webform_filter_alter(AlterableInterface $query) {

The description for that hook should also say for which tag that hook is implemented.

/**
 * Implements hook_entity_presave().
 *
 * Maps domain id on new werform create/duplicate.
 */
function domain_access_webform_webform_presave(WebformInterface $entity) {

Please update the hook description to reflect the correct usage. The hook_ENTITY_TYPE_presave() hook is being used. Additionally, specify the entity for which this hook is implemented.

2. FILE: src/DomainWebformService.php

  /**
   * Sets class variables.
   *
   * @param \Drupal\Core\Entity\EntityTypeManager $entityTypeManager
   *   Manages entity type plugin definitions.
   * @param \Drupal\Core\Logger\LoggerChannelFactory $logger
   *   Describes a logger instance.
   * @param \Drupal\Core\Session\AccountInterface $currentUser
   *   Defines an account interface which represents the current user.
   */
  public function __construct(

FILE: modules/domain_webform_mapper/src/DomainWebformMapper.php

  /**
   * Sets class variables.
   *
   * @param \Drupal\Core\Entity\EntityTypeManager $entityTypeManager
   *   Manages entity type plugin definitions.
   * @param \Drupal\Core\Logger\LoggerChannelFactory $logger
   *   Describes a logger instance.
   */
  public function __construct(

FILE: modules/domain_webform_mapper/src/Form/WebformDomainUpdateForm.php

  /**
   * Constructs the service objects.
   *
   * Class constructor.
   */
  public function __construct(EntityTypeManagerInterface $entityTypeManager, FileSystem $fileSystem) {

FILE: modules/domain_webform_mapper/src/Form/WebformSubmissionDomainUpdateForm.php

  /**
   * Constructs the service objects.
   *
   * Class constructor.
   */
  public function __construct(EntityTypeManagerInterface $entityTypeManager, FileSystem $fileSystem) {

The documentation comment for constructors is not mandatory anymore, If it is given, the description must be Constructs a new [class name] object. where [class name] includes the class namespace.

Rest seems fine to me.

Let’s wait for other reviewers to take a look and if everything goes fine, you will get the role.

As a side note, it will not be possible to opt this project into security advisory coverage until July 16, 2024.

@apaderno can you please Review it again as its already 19th July.

I am changing priority as per Issue priorities.

• The following points are just a start and don't necessarily encompass all the changes that may be necessary
• A specific point may just be an example and may apply in other places
• A review is about code that does not follow the coding standards, contains possible security issues, or does not correctly use the Drupal API; the single points are not ordered, not even by importance

src/Plugin/views/filter/FilterWebformByDomain.php

\Drupal\views\Plugin\views\filter\StringFilter is not part of the public API and it cannot be used as parent class. \Drupal\views\Plugin\views\filter\FilterPluginBase can instead be used, since that is a base class.

@avpaderno I have added the suggested changes as per #13, please review.

This is an ajay-mallah's application; it is ajay-mallah who needs to make commits to fix what reported.

@avpaderno Its @ajay-mallah who has made fixes of #13 and committed the changes.

and being the co maintainer of the module, I have equal contribution in this module development so I am commenting here.

It's ajay-mallah who needs to reply here and make the necessary changes, not every project maintainer.
This is not an application to review what the project maintainers as group understand about writing secure code which correctly uses the Drupal API and follows the Drupal coding standards. This is ajay-mallah's application.

Changing the parent class is not sufficient. The methods implemented by (and the code used in) StringFilter are different from the methods implemented by (and the code used in) FilterPluginBase.

Furthermore, FilterPluginBase is an abstract class. It means there are methods it does not implement which should be instead implemented by the child classes.

1. 1.0.x-alpha is a wrong name for a branch. Release branch names always end with the literal .x as described in Release branches.

as Its already been more than 2 months for this issue to be in the state of review, so changing the priority

manual review:
domain_webform_mapper.routing.yml: use permissions instead of roles to control access, which is more flexible.

Looks good to me otherwise.

Thanks for your contribution, Ajay!

I updated your account so you can opt into security advisory coverage now.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.