Problem/Motivation

Since 10.3 dialog:after/before/create/close events are vanilla JS events. not jQuery events

Backward compatibility only covers event listeners.
https://www.drupal.org/node/3422670

But this module seems triggers events itself. To be compatible with Drupal 10.3 it should trigger events in same style as core does
This MR for more info https://www.drupal.org/project/drupal/issues/3390549

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork bootstrap4_modal-3457776

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

finnsky created an issue. See original summary.

finnsky opened merge request !13

finnsky changed the visibility of the branch 3457776-update-events-triggers to hidden.

finnsky’s picture

finnsky commented
Category: Feature request » Bug report
Priority: Normal » Critical
Status: Active » Needs review
karlshea’s picture

karlshea
he/him
Primary language English
Location Minneapolis 🇺🇸
commented
Version: 2.1.7 » 2.x-dev
karlshea’s picture

karlshea
he/him
Primary language English
Location Minneapolis 🇺🇸
commented
Related issues: +#3456410: Mercury Editor dialogs won't open after upgrading to Drupal core 10.3

Using same approach as mercury_editor in #3456410: Mercury Editor dialogs won't open after upgrading to Drupal core 10.3.

Works for me in 10.3 but needs testing in 10.2.

finnsky’s picture

finnsky commented

I've added one comment

nikathone’s picture

nikathone
Primary language Swahili
Location Ontario
commented

I was having js errors when attempting to close the modal and the latest code in the MR fix the issue.

vhin0210 made their first commit to this issue’s fork.

  • 34a1b681 committed on 2.x 
    Update events triggers - #3457776
vhin0210’s picture

vhin0210 commented
Status: Needs review » Fixed
vhin0210’s picture

vhin0210 commented

nikathone changed the visibility of the branch 3457776-fix-triggers to hidden.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.