Closed (fixed)
Project:
Mercury Editor
Version:
2.1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
22 Jun 2024 at 12:10 UTC
Updated:
16 Jul 2024 at 13:14 UTC
Jump to comment: Most recent
Comments
Comment #2
d34dman commentedI was trying to see if I can fix this issue. While trying to compile the source file, I notice that it tries to build from `modules/mercury_editor_inline_editor` as well. But looks like it is safe to ignore that?
Comment #3
d34dman commentedComment #6
pbabin commentedWe are experiencing the same issue with ME and upgrading to 10.3
Comment #7
alisonSame here! I go into the node editing form (existing basic page with mercury editor enabled, and layout paragraphs functionality), and I get this in browser console (Firefox on Windows 11):
When I click the "plus" icon, it loads the paragraph picker dialog, but there's this in console:
Then I pick a paragraph type (button, in my case, because it's simple, just a plain text field and a link URL field), and the next dialog loads, but I get this in console:
Then, I fill in the two simple fields, and hit "Save" -- nothing happens, dialog stays up, no button is added to my layout -- and I get this in console:
"Cancel" also doesn't work, but the "X" at the top-right of the dialog does work, so that's how I make my escape.
Comment #10
justin2pin commentedHopefully MR55 is the ticket - this change dispatches the custom DrupalDialogEvent instead of using jQuery's trigger. This needs testing for backwards compatibility.
Comment #11
pbabin commentedPatched with MR55 in Drupal 10.3 without an issue and confirmed previous failing Cypress tests on our end our now passing. Thank you @just2pin for such a quick update.
Comment #12
sethhill commentedI installed this patch into a D10.2 site to test, and get this error:
Uncaught ReferenceError: DrupalDialogEvent is not definedSo this MR requires 10.3 as it stands at this moment.
Comment #13
alisonMR55 works for me on 10.3, too (was going to test on 10.2.6 buuuut thank you @sethhill for already doing that!)
Comment #14
sethhill commentedTested on 10.2 and 10.3, and the latest changes seem to work well.
Comment #16
justin2pin commentedComment #17
smurfxx commentedHas this patch already been deployed or does it need to be applied manually? I wanted to test Mercury Editor but I'm on Drupal 10.3.0 and I'm getting the AJAX error shown above.
Comment #18
d34dman commented@smurfxx, are you testing using 2.1.x-dev version?
Comment #19
smurfxx commentedYes, I'm testing the 2.1.0+9-dev version