Problem/Motivation

When adding new media the css for vertical tabs need be a dependencie.
Otherwise the variables in the css like '--vertical-tabs-menu-width' are not defined.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3457528.patch403 byteswouter waeytens

Comments

Wouter Waeytens created an issue. See original summary.

wouter waeytens’s picture

StatusFileSize
new403 bytes
cilefen’s picture

Version: 11.0.x-dev » 11.x-dev
Component: media system » Claro theme
Status: Active » Needs review
cilefen’s picture

Please open a merge request.

smustgrave’s picture

Status: Needs review » Needs work
Issue tags: +Needs issue summary update

What's the issue exactly though?

If a UI issue the summary should be updated to include before/after screenshots, also proposed solution.

gauravvvv’s picture

Otherwise the variables in the css like '--vertical-tabs-menu-width' are not defined.

The variable --vertical-tabs-menu-width is defined in the variable.pcss.css file, and it is available globally. So there's no need to add the dependency of claro/vertical-tabs

saurav-drupal-dev’s picture

To clarify, are there scenarios where the vertical-tabs-menu-width variable isn't available globally in other themes, or is this issue limited to Claro? It might be helpful to confirm if adding the dependency solves similar cases across custom themes or if this fix should be strictly scoped to the Claro theme.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

Status: Needs work » Postponed

The Claro theme was approved for removal in #3576460: [policy, no patch] Deprecate and remove Claro.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3576668: [meta] Tasks to deprecate Claro and the removal work in #3584638: [meta] Tasks to remove the Claro theme.

smustgrave’s picture

Project: Drupal core » Claro
Version: main » 3.0.x-dev
Component: Claro theme » Code
Status: Postponed » Postponed (maintainer needs more info)
Issue tags: +Needs screenshots

Claro has moved to contrib

But IS needs to be updated before it can be worked on. Especially screenshots please.