Problem/Motivation

Now that Drupal 11 is in beta, let's support it.

An Upgrade Status module scan identifies the following issues:

web/modules/dev/encrypt/tests/src/Unit/Entity/EncryptionProfileTest.php	87	Call to deprecated method setMethods() of class PHPUnit\Framework\MockObject\MockBuilder: https://github.com/sebastianbergmann/phpunit/pull/3687
web/modules/dev/encrypt/tests/src/Unit/Entity/EncryptionProfileTest.php	103	Call to deprecated method setMethods() of class PHPUnit\Framework\MockObject\MockBuilder: https://github.com/sebastianbergmann/phpunit/pull/3687
web/modules/dev/encrypt/tests/src/Unit/Entity/EncryptionProfileTest.php	205	Call to deprecated method setMethods() of class PHPUnit\Framework\MockObject\MockBuilder: https://github.com/sebastianbergmann/phpunit/pull/3687
web/modules/dev/encrypt/tests/src/Unit/Entity/EncryptionProfileTest.php	239	Call to deprecated method setMethods() of class PHPUnit\Framework\MockObject\MockBuilder: https://github.com/sebastianbergmann/phpunit/pull/3687
web/modules/dev/encrypt/tests/src/Unit/Entity/EncryptionProfileTest.php	267	Call to deprecated method setMethods() of class PHPUnit\Framework\MockObject\MockBuilder: https://github.com/sebastianbergmann/phpunit/pull/3687

Issue fork encrypt-3448070

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ptmkenny created an issue. See original summary.

ptmkenny opened merge request !7

ptmkenny’s picture

ptmkenny commented
Issue summary: View changes
ptmkenny’s picture

ptmkenny commented
Related issues: +#3130606: MockBuilder::setMethods is deprecated in PHPUnit8 and removed from PHPUnit10
ptmkenny’s picture

ptmkenny commented
Status: Active » Needs review

I updated the tests and removed support for Drupal 8 since PHPUnit 10 requires Drupal 9 at a minimum.

rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented

Thanks for this. I'm hesitant to drop support for Drupal 8 only because of tests. If the module still works with D8, I'd like it to still be installable, even though tests can't be run.

ptmkenny’s picture

ptmkenny commented

Ok, updated!

ptmkenny’s picture

ptmkenny commented
Status: Needs review » Needs work

Automated tests are failing so setting to "Needs work".

jcnventura’s picture

jcnventura
Primary language English
commented

At this moment, and since this is only changing the tests directory, removing support for D8 and D9 would not be entirely justified.
There's still about 170K sites out there running D8 and D9, and maybe they can't upgrade to the next major for some reason, but could keep up with this module.

ptmkenny’s picture

ptmkenny commented
Status: Needs work » Needs review

Ok, tests are now green, so I'm setting to "Needs Review."

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs review » Needs work

Test modules should not have a core_version_requirement as long as they are in package: Testing. See https://www.drupal.org/node/3070687#test

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs work » Needs review
jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Taking into account the fact that rector didn't find anything else to be fixed (https://dev.acquia.com/drupal11/deprecation_status/projects/encrypt) and that this only changes tests, and they are now passing, I think this can be merged.

Marking RTBC even if I was the last one committing, since my change was really minor.

rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented
Status: Reviewed & tested by the community » Fixed

This is fantastic, thanks!

  • rlhawk committed b9176b2f on 8.x-3.x authored by ptmkenny 
    Issue #3448070 by ptmkenny, jcnventura, rlhawk: Add support for Drupal...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.