Problem/Motivation

Pipeline fails with the current HEAD

Steps to reproduce

Check the pipeline runs

Proposed resolution

Fix tests/phpcs etc

Remaining tasks

Implement and review

User interface changes

None

API changes

None

Data model changes

None

Issue fork reroute_email-3447909

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Taran2L created an issue. See original summary.

Taran2L opened merge request !85

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented
Status: Active » Needs review

Rajeshreeputra made their first commit to this issue’s fork.

diwakar07’s picture

diwakar07 commented
Status: Needs review » Needs work

cspell job is still failing.
Please check: https://git.drupalcode.org/project/reroute_email/-/jobs/1664623

diwakar07’s picture

diwakar07 commented
Status: Needs work » Needs review

Hi, all the Gitlab checks are green now.
Please review.

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented

@Diwakar07 @Rajeshreeputra just adding all the incorrect words to the ignore list is not the correct solution

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented

@Taran2L, I agree with your point. Although the spelling does not correspond to an actual word, considering that we are using it for a variable name and also username(on D.O), we should be good to proceed.

I am open to suggestions on this.

diwakar07’s picture

diwakar07 commented

Hi @Rajeshreeputra, Taran2L
I have updated the list of ignored words and removed the some words(the ones that were used in README and for providing examples of configuring the module) that does make any change to the working of the module.
I think rest of the words are required to be ignored.
Please review.

ankitv18 made their first commit to this issue’s fork.

ankitv18’s picture

ankitv18 commented

Did some tweaks to fix cspell and phpcs pipeline ~~ marking this one RTBC

ankitv18’s picture

ankitv18 commented
Status: Needs review » Reviewed & tested by the community
ankitv18’s picture

ankitv18 commented
Component: Tests » Code
rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented

The changes appear to be in good, will plan to proceed with merge by this week.

bohart made their first commit to this issue’s fork.

bohart opened merge request !94

bohart closed merge request !85

  • bohart committed cdee76e4 on 2.3.x 
    Issue #3447909 by ankitv18, taran2l, diwakar07, rajeshreeputra, bohart:...
bohart’s picture

bohart
Location Lutsk, Ukraine
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +Coding standards

2.3.x branch is green now. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.