Needs work
Project:
Purge
Version:
8.x-3.5
Component:
Code
Priority:
Major
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
16 May 2024 at 08:50 UTC
Updated:
21 Jul 2026 at 19:41 UTC
Jump to comment: Most recent
Problem/Motivation
This issue resolves to make use of new features, and fix deprecations.
- Add Autowiring aliases so we can autowire Purge services into our own project services — https://www.drupal.org/node/3323122
- Switch to Logger injection via autoconfiguration — https://www.drupal.org/node/3395436
- Switch to event subscriber autoconfiguration so we dont need to add tags. — https://www.drupal.org/node/3357408
- DiagnosticsService and TagsHeadersService make use of the ContainerAwareTrait/Interface which is deprecated and being removed. The usage of this is exclusively for "lazy-loading" the services. We can switch to service closures in order to keep this lazy behaviour. — https://www.drupal.org/node/3360604
Proposed resolution
The proposed changes require Drupal 10.2, which in a few weeks will be the lowest supported version of Drupal. So we can up the Purge project minimums.
Update services.yml and add appropriate infrastructure to make use of new features
The changes here introduce no new behaviours.
Remaining tasks
Review, test, commit
User interface changes
None
API changes
Changes to some service constructors
Changes to internals of our services that wouldnt be expected to be modified downstream or have an API contract.
Data model changes
Nil.
Issue fork purge-3447548
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
japerryThanks for looking at this, as it will be required for D11 compatibility. I've added this issue to our internal D11 tracker as well.
Comment #4
moshe weitzman commentedThis hasn't run since the switch to Gitlab 3 months ago. A bunch of D11 compat went in.
Comment #5
dpiMerged into head and fixed broken things.
Back to passing.
Current head is not passing, so I've cherry picked in #3565396: Make @dataProvider methods static. That issue should go in first.
Head linting is also a mess, so I havnt tried to touch that.
Comment #6
liam morlandComment #7
dpiSure, a re-roll might be required. But it doesnt stop a review.
I'd rather not infinitely re-roll a MR when a maintainer may choose to require significant reworks or outright decline.
Maintainers please provide feedback on the current MR. You may feel free to merge the work in and resolve conflicts yourself, or request a reroll then.
Lets be respectful of eachothers time.
Comment #8
dpi@maintainers I'll put it out there that I'm available to maintain if you so desire, I've put significant time into Purge ecosystem recently and have a bit of capacity to get things into shape (test/lint-wise).
Comment #9
japerryAs written, this will break most modules implementing purge. I'm tempted to mark 'Won't fix' -- however, there might be some snippets of this patch that we can incrementally introduce without needing to bump major version compatibility.