Problem/Motivation

In tests, the @dataProvider methods must now be static.

Steps to reproduce

Run tests on Drupal 11.

Proposed resolution

Make them static.

Remaining tasks

Implement.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork purge-3565396

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

petar_basic created an issue. See original summary.

petar_basic opened merge request !58

petar_basic’s picture

petar_basic commented
Status: Active » Needs review

liam morland made their first commit to this issue’s fork.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Title: Make 3.x gitlab-ci tests green » Make @dataProvider methods static
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

This is the correct fix. Tests are passing.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Priority: Normal » Major

This should be merged before anything else so that tests can be run on the other issues.

dpi’s picture

dpi
Location Perth, Australia
commented
Assigned: petar_basic » Unassigned

Looks like this blocks #3447548: Clean up services, add autowiring, make use of new features, and fix deprecations and #3564459: Drupal 11.3 compatibility: Not supporting attribute discovery in Drupal\purge\Plugin\Purge\Processor\PluginManager

  • 3878e677 committed on 8.x-3.x 
    #3565396: Fix test failures.
japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Fixed

Looks good! Fixed!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.