Problem/Motivation

When you go to /admin/structure/webform/config, you see Please login to access this form as Default access denied message, when it should have been Please log in to access this form.

Steps to reproduce

Go to /admin/structure/webform/config

Proposed resolution

A patch will follow.

Remaining tasks

N/A

User interface changes

A patch to change the text will follow.

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#6 AfterPatchWebforms.png49.78 KBriddhi.addweb
#6 Webforms-Forms-configuration-Drush-Site-InstallBeforepatch.png177.37 KBriddhi.addweb
#2 3447208-2.patch11.28 KBkartagis

Issue fork webform-3447208

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Kartagis created an issue. See original summary.

kartagis’s picture

kartagis
Primary language Turkish
Location Istanbul
commented
StatusFileSize
new 3447208-2.patch11.28 KB
kartagis’s picture

kartagis
Primary language Turkish
Location Istanbul
commented
Status: Active » Needs review
cilefen’s picture

cilefen commented

I, too, agree that “login” is a noun and “log in” is a verb.

Should this migrate unchanged configs?

cilefen’s picture

cilefen commented

Actually “login” is an adjective.

riddhi.addweb’s picture

riddhi.addweb commented
StatusFileSize
new Webforms-Forms-configuration-Drush-Site-InstallBeforepatch.png177.37 KB
new AfterPatchWebforms.png49.78 KB

I have applied the patch and mentioned the content changes are there. I also checked with the Grammarly plugin, and it says "log in" is correct.

riddhi.addweb’s picture

riddhi.addweb commented
Status: Needs review » Reviewed & tested by the community
cilefen’s picture

cilefen commented
Status: Reviewed & tested by the community » Needs work

We did not discuss comment #4.

kartagis’s picture

kartagis
Primary language Turkish
Location Istanbul
commented

@cilefen what exactly do you mean in #4?

cilefen’s picture

cilefen commented

This issue is changing the default configuration but not updating existing configurations, even if they have not been changed from the default.

kartagis’s picture

kartagis
Primary language Turkish
Location Istanbul
commented

What do you suggest I do? Maybe do something like the below in a hook_update_N?

$config = \Drupal::service('config.factory')->getEditable('webform.settings')->get('settings');
$message = 'Please log in to access this form.';
foreach (['default_form_access_denied_message', 'default_submission_access_denied_message', 'file_private_redirect_message'] as $key) {
    $config[$key] = $message;
}

Kartagis opened merge request !472

jrockowitz made their first commit to this issue’s fork.

jrockowitz’s picture

jrockowitz commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.