Problem/Motivation

When I run kernel tests, I get these self deprecation notices:

Remaining self deprecation notices (15)

10x: The Drupal\Tests\field\Traits\EntityReferenceTestTrait is deprecated in drupal:10.2.0 and is removed from drupal:11.0.0. Instead, use \Drupal\Tests\field\Traits\EntityReferenceFieldCreationTrait. See https://www.drupal.org/node/3401941
1x in KernelTestSuite::suite from Drupal\Tests\TestSuites
1x in EntityReferenceTest::testUpdatingMissingReferences from Drupal\Tests\feeds\Kernel\Feeds\Target
1x in EntityReferenceTest::testUpdatingMissingNodeAuthors from Drupal\Tests\feeds\Kernel\Feeds\Target
1x in EntityReferenceTest::testUpdatingMissingParentTerms from Drupal\Tests\feeds\Kernel\Feeds\Target
1x in EntityReferenceTest::testWithSingleReference from Drupal\Tests\feeds\Kernel\Feeds\Target
...

3x: Calling createUser() with $values as the first parameter is deprecated in drupal:10.1.0 and will be removed from drupal:11.0.0. Use createUser(array $permissions = [], $name = NULL, $admin = FALSE, array $values = []) instead. See https://www.drupal.org/node/3330762
2x in RevisionableEntityTest::testWithMappingToRevisionFields from Drupal\Tests\feeds\Kernel
1x in UserRoleTest::testImportWithExistingRole from Drupal\Tests\feeds\Kernel\Feeds\Target

2x: Deprecated NULL placeholder value for key (@feed) in: "@feed: There are no new @items.". This will throw a PHP error in drupal:11.0.0. See https://www.drupal.org/node/3318826
2x in FeedTest::testDispatchImportFinishedEvent from Drupal\Tests\feeds\Kernel\Entity

Steps to reproduce

Run phpunit --testsuite="kernel" --group="feeds"

Proposed resolution

See referenced article for each deprecation.

CommentFileSizeAuthor
#2 3437473-2.patch3.2 KBdineshkumarbollu

Issue fork feeds-3437473

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

ryanrobinson_wlu created an issue. See original summary.

dineshkumarbollu’s picture

Status: Active » Needs work
StatusFileSize
new3.2 KB

Created patch, please review.

dineshkumarbollu’s picture

Status: Needs work » Needs review
ptmkenny’s picture

Version: 8.x-3.0-beta4 » 8.x-3.x-dev
Status: Needs review » Needs work

@dineshkumarbollu Thanks for this patch! Could you please submit it as an MR? Feeds has GitLab CI tests enabled, so we can easily confirm that the issues are fixed if you submit a merge request.

ankitv18 made their first commit to this issue’s fork.

ankitv18’s picture

Assigned: Unassigned » ankitv18

ankitv18’s picture

Status: Needs work » Needs review

@MegaChriz this one is ready for review

ankitv18’s picture

Assigned: ankitv18 » Unassigned

MegaChriz made their first commit to this issue’s fork.

megachriz’s picture

Status: Needs review » Fixed

Thanks! I merged the code.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.