Steps to reproduce

1. Create a content type
2. Add a content
3. CSS is broken on the content view page.

Issue fork business-3436639

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Neha Wadhwani created an issue. See original summary.

neha wadhwani’s picture

Assigned: neha wadhwani » Unassigned
Status: Needs work » Needs review
StatusFileSize
new41.13 KB
new1.37 KB
hritick’s picture

I cant seem to apply your patch and I am using drupal 9.5.11. While applying the patch it fails.

ashutosh ahirwal’s picture

Status: Needs review » Needs work
Issue tags: +Novice

Instant of adding display none to each field label, set the label hidden from manage display form for content type.

sourojeetpaul’s picture

Assigned: Unassigned » sourojeetpaul
StatusFileSize
new182.56 KB

Hello, @Neha Wadhwani, I cannot find any style breaking issue on the content view page, I think what you meant here is the field labels coming in the full view mode which can be easily mitigated as correctly suggested by @Ashutosh from the manage display setting. But while trying to reproduce this issue I've observed rather another issue which caught my attention, is that the tabs are aligned vertically which is a bit weird, I think it'll be better if its aligned horizontally, and should only appear vertically through a hamburger menu menu on smaller screens. So I'm fixing that within this issue itself!
Attaching a screenshot for reference!
Tabs

sourojeetpaul’s picture

Assigned: sourojeetpaul » Unassigned
Status: Needs work » Needs review
StatusFileSize
new311.52 KB
new50.14 KB

I've resolved the issue that I mentioned on the previous comment, also observed that its a common behaviour for the primary tabs local task that's why it was affecting all the tabs, including the login page tabs. So in my commit I've addressed it globally which mitigates the issue. Please have a look:
https://git.drupalcode.org/project/business/-/merge_requests/17
Attaching screenshots for reference!

esha_kundu’s picture

Status: Needs review » Reviewed & tested by the community

Hi,
I came across the same design issue with the tabs with this theme and I have applied the MR!17 which resolves the design issue.
I have attached the before and after ss.
Moving to RTBC.

Before patch
Only local images are allowed.

After patch
Only local images are allowed.

gauravvvv’s picture

Status: Reviewed & tested by the community » Fixed
gauravvvv’s picture

Thank you for working on the issue, committed to 9.1.x and 10.0.x

esha_kundu’s picture

Hello @Gauravvvv,
As per granting credits, the contributor reviewing a patch and moving the issue foward to fixing the issue can be granted credit.
https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquette/granting-credit-to-issue-contributors
In this regard I haven't been granted credit. It would be great if you grant credit to me.
Thank you

gauravvvv’s picture

As per granting credits, the contributor reviewing a patch and moving the issue foward to fixing the issue can be granted credit.
https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett...
In this regard I haven't been granted credit. It would be great if you grant credit to me.
Thank you

Hello @esha_kundu, Thank you for contributing to the issue. I noticed that you have not added any screenshots or provided the steps to test it. Additionally, the "before" and "after" patch images you included are giving a 404 error and are not being displayed. Credits are granted for valuable contributions that help move the issue forward.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.