Closed (fixed)
Project:
Business
Version:
9.1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
28 Mar 2024 at 06:56 UTC
Updated:
27 Jun 2024 at 03:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
neha wadhwani commentedComment #3
hritick commentedI cant seem to apply your patch and I am using drupal 9.5.11. While applying the patch it fails.
Comment #4
ashutosh ahirwal commentedInstant of adding display none to each field label, set the label hidden from manage display form for content type.
Comment #5
sourojeetpaul commentedHello, @Neha Wadhwani, I cannot find any style breaking issue on the content view page, I think what you meant here is the field labels coming in the full view mode which can be easily mitigated as correctly suggested by @Ashutosh from the manage display setting. But while trying to reproduce this issue I've observed rather another issue which caught my attention, is that the tabs are aligned vertically which is a bit weird, I think it'll be better if its aligned horizontally, and should only appear vertically through a hamburger menu menu on smaller screens. So I'm fixing that within this issue itself!

Attaching a screenshot for reference!
Comment #7
sourojeetpaul commentedI've resolved the issue that I mentioned on the previous comment, also observed that its a common behaviour for the primary tabs local task that's why it was affecting all the tabs, including the login page tabs. So in my commit I've addressed it globally which mitigates the issue. Please have a look:
https://git.drupalcode.org/project/business/-/merge_requests/17
Attaching screenshots for reference!
Comment #8
esha_kundu commentedHi,
I came across the same design issue with the tabs with this theme and I have applied the MR!17 which resolves the design issue.
I have attached the before and after ss.
Moving to RTBC.
Before patch

After patch

Comment #11
gauravvvv commentedComment #12
gauravvvv commentedThank you for working on the issue, committed to 9.1.x and 10.0.x
Comment #13
esha_kundu commentedHello @Gauravvvv,
As per granting credits, the contributor reviewing a patch and moving the issue foward to fixing the issue can be granted credit.
https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquette/granting-credit-to-issue-contributors
In this regard I haven't been granted credit. It would be great if you grant credit to me.
Thank you
Comment #14
gauravvvv commentedHello @esha_kundu, Thank you for contributing to the issue. I noticed that you have not added any screenshots or provided the steps to test it. Additionally, the "before" and "after" patch images you included are giving a 404 error and are not being displayed. Credits are granted for valuable contributions that help move the issue forward.