Automated Drupal 11 compatibility fixes for quickedit

@ankitv18 why would you remove upgrade status ci pipeline?
Also, phpstan pipelines need more love.

Basically upgrade_status reports same as phpstan so it's ideal to avoid running extra jobs and just focusing on to fix phpunit first then I'll restore the upgrade_status in the pipeline.

Need to fix phpunit errors and the following phpstan errors

 ------ --------------------------------------------------------------- 
  Line   tests/src/Unit/Access/QuickEditEntityFieldAccessCheckTest.php  
 ------ --------------------------------------------------------------- 
  83     Trying to mock an undefined method get() on class              
         Drupal\Core\Entity\EntityInterface.                            
  87     Trying to mock an undefined method hasTranslation() on class   
         Drupal\Core\Entity\EntityInterface.                            
 ------ --------------------------------------------------------------- 

The remaining tests are failing because the library quickedit.inPlaceEditor.formattedText is not attached during testing. I will investigate further to determine the root cause.

I have fixed most of the failing tests only 2 similar test are failing.

1. Drupal\Tests\quickedit\FunctionalJavascript\LayoutBuilderIntegrationTest::testArticleNode - This caused by empty body field value
2. Drupal\Tests\quickedit\FunctionalJavascript\CKEditor5IntegrationTest::testArticleNode - Not sure why saving state isn't available for body field

Created a separate issue to cover the 2 pipeline issue and require a fresh set of eyes on them as that has dependency on ckeditor 5 module. Hence moving this ticket into review.

I'm trying to apply this patch agains version 1.0.3 and it does not work, it only seems to work with 1.0.x, should this be the case?
I'm currently just adding the patch under extra, patches in my composer.json file.
Setting as needs review as I would expect it to apply.

Yes @darrenwh , you cannot apply a patch for this module for an older version, you need to apply against dev [1.0.x].

Note: You can update your composer.json to load quickedit module dev version and then apply the patch in extra section and it will work fine.

With these patches is quickedit working in Drupal 11?

Works great!

Thanks — works flawlessly! RTBC +1. Eagerly awaiting the release.

Thanks this works Great !!

RTBC + 2

Works great on my Drupal 11.2.0 clean install.

I will leave below the steps that i had to follow, maybe can help someone else in the future too.

Check it out this page

I ran this commands to start from stratch, using ddev:

ddev composer create-project drupal/recommended-project
ddev config --project-type drupal --docroot web
ddev start
ddev composer create-project drupal/recommended-project
** ddev composer require mglaman/composer-drupal-lenient **
ddev composer config --merge --json extra.drupal-lenient.allowed-list '["drupal/quickedit"]'
ddev composer require cweagans/composer-patches
ddev composer require --dev drush/drush
ddev drush site:install --account-name=admin --account-pass=admin -y
ddev composer require drupal/ctools; ddev drush en ctools
ddev composer require drupal/entity; ddev drush en entity
ddev composer require drupal/libraries; ddev drush en libraries
ddev composer require drupal/quickedit; ddev drush en quickedit 

[here we added the libraries required and the merge request patch]

ddev composer update drupal/quickedit
ddev launch

** This was done to remove a barrier with getting extensions installed via Composer to work on making modules Drupal 11 ready.

After that i created a test article and the result works as expected i could change the title of my article.

Just a static patch of the MR to be used on composer.

Hey Murilo,

you could just add ".diff" at the end of the MR link, and we are go to go on composer. :)

Like: https://git.drupalcode.org/project/quickedit/-/merge_requests/18.diff

@mutilohp: i am not able to apply patch , please check my screenshot for the same , please let me know if am doing anything wrong in the project.

Hi @brahmjeet789, Murilo just tried to give us another way to fix with the MR we currently have.

did you tried to check the proposal MR with the steps at #27?

@igorgoncalves the issue with using a direct link to the merge request (MR) is that I can't lock it to a specific version. If someone updates the MR, I'll always receive the latest version. This means if someone commits something incorrect, I'll end up with that version.

@brahmjeet789, the patch is basically the content of the merge request, since the MR is pointing to the dev branch, you'll have to use it, here I'm applying it to the dev-1.0.x#62e8dd618, my composer has the following requirement

"drupal/quickedit": "dev-1.0.x#62e8dd618516b8f177615cac26d6ccefe21e067a",

I hope this helps you. And moving this back to RTBC

You're right Murilo.
Thanks for the update.

@murilohp : still ihave got an errro when i am using dev branch , could you please check it , please help me to resolve this issue .

@murilohp : i have created patch for the same , please look into it , if it is fine , please let me know.

@Murilohp: added new revised patch for the same. please check and let us know if it is fine with latest branch.

@Murilohp: added new revised patch for the same. please check and let us know if it is fine with latest branch.

Hello Team,

When we will get the Drupal 11 compatible release ?

Thanks

Can we get the D11 version released, please?

Looks good. Tested on D11.

Please create a Drupal 11 release.

Thank you. Committed. 🍻